Repository navigation
Conversation
rustbot
added
the
S-waiting-on-review
| pub struct X; | ||
| ``` | ||
|
|
||
| Tool attributes exist in the [tool prelude], so items explicitly brought into scope as well as the [extern prelude] will shadow them. As these paths can only resolve to either an attribute macro, which is ambiguous, something that isn't valid in an attribute, or only partially resolve, shadowing a tool attribute in this way is also an error. |
Contributor
There was a problem hiding this comment.
Suggested change
| Tool attributes exist in the [tool prelude], so items explicitly brought into scope as well as the [extern prelude] will shadow them. As these paths can only resolve to either an attribute macro, which is ambiguous, something that isn't valid in an attribute, or only partially resolve, shadowing a tool attribute in this way is also an error. | |
| Tool attributes exist in the [tool prelude], so items explicitly brought into scope as well as items in the [extern prelude] will shadow them. As these paths can only resolve to either an attribute macro, which is ambiguous, something that isn't valid in an attribute, or only partially resolve, shadowing a tool attribute in this way is also an error. |
the second sentence is also a bit hard to read - my understanding is that this is saying that the paths can only
- resolve to an attribute macro (and resolving to that is ambiguous)
- resolve to something that isn't valid in an attribute
- partially resolve
but it took a few read throughs to figure that out
Member
Author
There was a problem hiding this comment.
Yeah, I'm not sure about the wording either, suggestions welcome.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accompanies the changes in rust-lang/rust#162597