[bjorn3]

This should make it easier to move the driver interface away from queries in the future. Many custom drivers call queries like queries.global_ctxt() before they are supposed to be called, breaking some things like certain --print and -Zunpretty options, -Zparse-only and emitting the dep info at the wrong point in time. They are also not actually necessary at all. Passing around the query output manually would avoid recomputation too and would be just as easy. Removing driver queries would also reduce the amount of global mutable state of the compiler. I'm not removing driver queries in this PR to avoid breaking the aforementioned custom drivers.

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

I disagree with this and would like to see everything expanded as a part of the regular expansion phase (that's why I introduced the current setup in #108221), that will allow to expand crate-level macro attributes correctly.
If some crate attribute has to be used before that, then it is an exception that should be clearly visible, such attributes need to have some restrictions (e.g. cannot be macro-generated).

Reverted

Seems like dep_graph.finish_encoding() needs to be called even if the incr comp session will never be finalized due to a compile error.

I can't reproduce the bug locally. I've dropped the offending commit for now.

Current state looks good to me. Thanks, @bjorn3!

Let's not put this into a rollup in case it causes unforeseen breakage.
@bors r+ rollup=never

📌 Commit 8d1f5b3 has been approved by michaelwoerister

It is now in the queue for this repository.

⌛ Testing commit 8d1f5b3 with merge fa89b04...

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

💔 Test failed - checks-actions

@bors retry spurious network issue

⌛ Testing commit 8d1f5b3 with merge c2d2bb3...

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing c2d2bb3 to master...

Finished benchmarking commit (c2d2bb3): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-5.3%, -0.2%]	2
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results (primary -4.2%, secondary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-4.2%	[-4.7%, -3.4%]	3
Improvements ✅ (secondary)	-4.4%	[-8.0%, -2.6%]	9
All ❌✅ (primary)	-4.2%	[-4.7%, -3.4%]	3

Cycles

Results (secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[2.0%, 8.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 693.956s -> 693.71s (-0.04%)
Artifact size: 324.65 MiB -> 326.75 MiB (0.65%)