Repository navigation
Port most of --print=target-cpus to Rust - #132514
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic and formatting needed by
--print=target-cpushas historically been carried out in C++ code. Originally it usedprintfto write directly to the console, but later it switched over to writing to astd::ostringstreamand then passing its buffer to a callback function pointer.This PR replaces that C++ code with a very simple function that writes a list of CPU names to a
&RustString, with the rest of the logic and formatting being handled by ordinary safe Rust code.