[tisonkun]

Tracking issue - #133125

r? @programmerjake @kennytm @Amanieu

This refers to rust-lang/libs-team#268

Before adding tests and creating a tracking issue, I'd like to reach a consensus on the implementation direction and two questions:

1. Whether we'd add a String::into_char_indices method also?
2. See inline comment.

[rustbot]

Failed to set assignee to programmerjake: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[tisonkun]

This reminds me of this thread that suggests a truncate_front method on Vec. Not sure if it's desired as a separate proposal.

Thanks for your review! It seems this direction is good to go. I'd create a tracking issue, update the attr in code and add docs with doctests, then request a review for merging.

Hopefully in this week.

This PR is ready for merge from my perspective.

Ping @programmerjake @kennytm @Amanieu if you have time to give it a review :D

I'd still wonder whether we'd add a String::into_char_indices method also? Seems intuitive and for symmetry.

Looks good, aside from some small nits:

• unsafe { self.bytes.advance_by(offset).unwrap_unchecked() } and let _ = self.bytes.advance_back_by(len - idx) should be consistent. I think ignoring with _ is better.
• Looks like iter and size_hint are missing #[inline].
• The crate::vec imports can be simplified from two lines to use crate::vec::{self, Vec} to match the other imports.

@thaliaarchi Thank you! Comments addressed.

@programmerjake Thanks for your information! I was told to do this sometime and not sure if there is a consensus or reference.

I've seen a number of PRs that were merged with multiple commits (e.g. just looking through git log I found #134601 which was merged with 2 separate commits), so my assumption is that's fine. I might rebase to squash commits that weren't useful to have separate (e.g. 5 commits in a row fixing typos could be 1 commit) but if the commits are useful to have separate, then afaict keep them separate if you prefer.

Hello @Amanieu! May we have another review around?

Sorry for the delay, I'm currently going through my PR review backlog.

@bors r+

📌 Commit 7218fd1 has been approved by Amanieu

It is now in the queue for this repository.