Add methods to TCP and UDP sockets to modify hop limit by Mallets · Pull Request #138744 · rust-lang/rust

Mallets · 2025-03-20T11:18:52Z

#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

implements the change suggested in add methods to TCP and UDP sockets to modify hop limit #94678 (comment)
defines set_multicast_hop_limit_v6 and multicast_hop_limit_v6 only for UDP sockets and not for TCP sockets as originally proposed

Issue: #139166

rustbot · 2025-03-20T11:19:02Z

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ibraheemdev · 2025-03-28T21:46:26Z

r? libs-api because it's been a while since the original PR was approved.

bors · 2025-04-13T08:05:55Z

☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay · 2025-04-13T16:23:19Z

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. .

dtolnay · 2025-04-13T16:24:11Z

@rustbot ready

dtolnay · 2025-04-13T16:25:33Z

Thank you!

@bors r+

bors · 2025-04-13T16:25:35Z

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

clarfonthey · 2026-10-03T17:54:20Z

@bors try jobs=various

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) try-job: *various*

rust-bors · 2026-10-03T19:44:18Z

💔 Test for b4e082d failed: CI. Failed jobs:

try - dist-various-2 (web logs, enhanced plaintext logs)
try - test-various (web logs, enhanced plaintext logs)

Mallets · 2026-10-05T09:39:00Z

eb18e7e fixes CI compilation for UEFI targets by returning unsupported().

Verified locally with:

./x build library/std --target aarch64-unknown-uefi,i686-unknown-uefi,x86_64-unknown-uefi

@rustbot ready

jhpratt · 2026-10-17T06:26:23Z

@bors squash

…st-lang#94678) * Add methods to TCP and UDP sockets to modify hop limit * Use IPv6 addresses in hop_limit_v6 docs * Update tracking issue to 139166 * Update docs according to PR review * Fix unused_variables * fix: add cfg guards on unsupported wasi p2 and p3 targets * fix: tidy PAL and unsafe blocks CI failure * fix: tidy CI * fix: port tests to new TCP testing framework * Trigger CI * Fix TCP hop limit doctest indentation * Use cfg_select for socket hop limit methods * fix: UEFI IPv6 hop-limit stubs return unsupported Co-authored-by: David Tolnay <dtolnay@gmail.com> Co-authored-by: Luca Cominardi <luca.cominardi@datadoghq.com>

rust-bors · 2026-10-17T06:26:44Z

🔨 13 commits were squashed into 52b5c71.

rustbot · 2026-10-17T06:26:50Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtrees.
- 52b5c71

jhpratt · 2026-10-17T06:28:03Z

@bors r+

rust-bors · 2026-10-17T06:28:06Z

📌 Commit 52b5c71 has been tentatively approved by jhpratt

It will be put into the queue for this repository once PR CI succeeds.

@kckeiks

…=jhpratt Add methods to TCP and UDP sockets to modify hop limit rust-lang#94678 was closed because of time constraints of the original author (@kckeiks). This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

Rollup of 10 pull requests Successful merges: - #161698 (Fix rmeta-link metadata not being read on AIX) - #163373 (Canonicalize operands for commutative binary ops) - #164016 (Tighten (absence of) return attribute checks in `some-abis-do-extend-params-to-32-bits.rs`) - #164424 (diagnostic: skip wrong loops when explaining borrow errors) - #138744 (Add methods to TCP and UDP sockets to modify hop limit) - #162444 (Make `std::fs::{File, ReadDir, DirEntry}` always `needs_drop` even when unsupported.) - #163862 (Collect all limit attributes during TyCtxt creation) - #164213 (make the safety documentation consistent in task::LocalWaker) - #164356 (Add missing full stop) - #164374 (core: hint: fix `unlikely`'s example polarity typo)

@kckeiks

…=jhpratt Add methods to TCP and UDP sockets to modify hop limit rust-lang#94678 was closed because of time constraints of the original author (@kckeiks). This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

…uwer Rollup of 11 pull requests Successful merges: - #162809 (Remap local def ids for deterministic metadata encoding) - #163373 (Canonicalize operands for commutative binary ops) - #164016 (Tighten (absence of) return attribute checks in `some-abis-do-extend-params-to-32-bits.rs`) - #164259 (std: make SOLID `sockaddr_storage` large enough for IPv6) - #164424 (diagnostic: skip wrong loops when explaining borrow errors) - #138744 (Add methods to TCP and UDP sockets to modify hop limit) - #162444 (Make `std::fs::{File, ReadDir, DirEntry}` always `needs_drop` even when unsupported.) - #163862 (Collect all limit attributes during TyCtxt creation) - #164213 (make the safety documentation consistent in task::LocalWaker) - #164356 (Add missing full stop) - #164374 (core: hint: fix `unlikely`'s example polarity typo)

rustbot assigned ibraheemdev Mar 20, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025

Mallets mentioned this pull request Mar 20, 2025

feat: Add TTL connection param to multicast eclipse-zenoh/zenoh#1842

Merged

rustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 28, 2025

rustbot assigned dtolnay and unassigned ibraheemdev Mar 28, 2025

dtolnay requested changes Mar 30, 2025

View reviewed changes

Comment thread library/std/src/net/tcp.rs Outdated

Comment thread library/std/src/net/tcp.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2025

Mallets mentioned this pull request Mar 31, 2025

Tracking Issue for #138744: Add methods to TCP and UDP sockets to modify IPv6 hop limits #139166

Open

4 tasks

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

This comment has been minimized.

Sign in to view

Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7f790e2 to 9c1ee90 Compare March 31, 2025 10:13

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

dtolnay force-pushed the set_ipv6_sock_hop_limit branch from 9c1ee90 to 25fb525 Compare April 13, 2025 16:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2025

dtolnay approved these changes Apr 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026

Auto merge of #138744 - Mallets:set_ipv6_sock_hop_limit, r=<try>

b4e082d

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) try-job: *various*

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the set_ipv6_sock_hop_limit branch from eb18e7e to 52b5c71 Compare October 17, 2026 06:26

jhpratt changed the title ~~Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)~~ Add methods to TCP and UDP sockets to modify hop limit Oct 17, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2026

jhpratt mentioned this pull request Oct 17, 2026

Rollup of 10 pull requests #164460

Closed

This was referenced Oct 17, 2026

Rollup of 10 pull requests #164478

Closed

Rollup of 11 pull requests #164479

Merged

rust-bors Bot merged commit 37a7c56 into rust-lang:main Oct 17, 2026
14 checks passed

This was referenced Oct 18, 2026

hermit building failed due to IPV6_UNICAST_HOPS and IPV6_MULTICAST_HOPS missing #164495

Open

motor building failed due to missing set_hop_limit_v6 hop_limit_v6 method #164496

Open

Conversation

Mallets commented Mar 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 20, 2025

Uh oh!

ibraheemdev commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

bors commented Apr 13, 2025

Uh oh!

clarfonthey commented Oct 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Oct 3, 2026

Uh oh!

Mallets commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Oct 17, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 17, 2026

Uh oh!

rustbot commented Oct 17, 2026

Uh oh!

jhpratt commented Oct 17, 2026

Uh oh!

rust-bors Bot commented Oct 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Mallets commented Mar 20, 2025 •

edited by rustbot

Loading

Mallets commented Oct 5, 2026 •

edited

Loading