[DAstapov]

Closes #159484

[rustbot]

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @folkertdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler, types
• compiler, types expanded to 74 candidates
• Random selection from 17 candidates

[folkertdev]

Seems OK, is this what you had in mind

r? estebank

View changes since this review

[chenyukang]

Scanning the entire body by textual name can select an unrelated shadowed binding and insert .await on a non-Future value.

for example:

async fn make_number() -> i32 {
    42
}

async fn f() {
    let number = make_number();
    println!("{number}");

    {
        let number = 0;
    }
}

View changes since the review

[chenyukang]

This fallback can still be reached for a captured format argument when the binding is not a top-level PatKind::Binding, for example:

async fn show() {
    let (number,) = (make_number(),);
    println!("{number}");
}

Here span is still inside the format string, so the suggestion produces println!("{number}.await"), which does not actually await the future.

View changes since the review

[rust-bors]

☔ The latest upstream changes (presumably #162640) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.