Skip to content

fd-views: AsRef<File>&Co. for BorrowedFd - #160404

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
the8472:fd-views
Oct 25, 2026
Merged

fd-views: AsRef<File>&Co. for BorrowedFd#160404
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
the8472:fd-views

Conversation

@the8472

@the8472 the8472 commented Aug 2, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

tracking issue: #160402

This uses #[unstable_feature_bound] so the trait impls are not insta-stable, so no FCP needed yet. But they're infectious to callers which means we currently can't dogfood the added API in std itself.

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 2, 2026
@rustbot rustbot added the O-windows Operating system: Windows label Aug 3, 2026
@the8472 the8472 mentioned this pull request Aug 3, 2026
Open
2 of 5 tasks
@the8472
the8472 marked this pull request as ready for review August 3, 2026 22:09
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt

jhpratt commented Aug 5, 2026

Copy link
Copy Markdown
Member

Let me know when CI is passing and I'll take a look.

@jhpratt jhpratt added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026
@rustbot

This comment has been minimized.

Sign in to view
@the8472

the8472 commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2026
@jhpratt

jhpratt commented Oct 17, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 335e8c8 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 17, 2026
@jhpratt
Rollup merge of rust-lang#160404 - the8472:fd-views, r=jhpratt
4c747aa 
fd-views: AsRef<File>&Co. for BorrowedFd

tracking issue: rust-lang#160402

This uses `#[unstable_feature_bound]` so the trait impls are _not_ insta-stable, so no FCP needed yet. But they're infectious to callers which means we currently can't dogfood the added API in std itself.
@jhpratt jhpratt mentioned this pull request Oct 17, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 17, 2026
@bors
Auto merge of #164456 - jhpratt:rollup-VUe9WNu, r=jhpratt
3b510ed 
Rollup of 10 pull requests

Successful merges:

 - #163731 (Add bootstrap step to build the TPDE plugin)
 - #160404 (fd-views: AsRef<File>&Co. for BorrowedFd)
 - #161698 (Fix rmeta-link metadata not being read on AIX)
 - #164016 (Tighten (absence of) return attribute checks in `some-abis-do-extend-params-to-32-bits.rs`)
 - #164424 (diagnostic: skip wrong loops when explaining borrow errors)
 - #162444 (Make `std::fs::{File, ReadDir, DirEntry}` always `needs_drop` even when unsupported.)
 - #163862 (Collect all limit attributes during TyCtxt creation)
 - #164213 (make the safety documentation consistent in task::LocalWaker)
 - #164356 (Add missing full stop)
 - #164374 (core: hint: fix `unlikely`'s example polarity typo)
@rust-bors

rust-bors Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Testing commit 335e8c8 with merge 0e257b5...

Workflow: https://github.com/rust-lang/rust/actions/runs/39019991801

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 21, 2026
@rust-bors

rust-bors Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#164658), which was unapproved.

View changes since this unapproval

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Any special-casing of Miri in the standard library requires review.

cc @rust-lang/miri

@rustbot

This comment has been minimized.

Sign in to view
RalfJung
RalfJung reviewed Oct 21, 2026
View reviewed changes
Comment thread library/std/src/os/fd/owned.rs
RalfJung
RalfJung reviewed Oct 21, 2026
View reviewed changes
Comment thread library/std/src/os/windows/io/handle.rs Outdated
@rustbot

rustbot commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@the8472

the8472 commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready
@bors rollup=iffy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2026
@jhpratt

jhpratt commented Oct 25, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit efbea8e has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 25, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Auto merge of #164894 - JonathanBrouwer:rollup-fyOlw75, r=JonathanBro…
5f39295 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #160404 (fd-views: AsRef<File>&Co. for BorrowedFd)
 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #163769 (reborrow: Fix various ICEs related to auto reborrowing of user-space types)
 - #164764 (Test(lib/sync): Fix `test_rwlock_max_readers` for 32bit architectures)
 - #164860 (std::fs: read interrupted by a signal, read_buf_exact_at reports EOF.)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #163510 (process: Improve the output of `Debug` for `ExitStatus` on Unix)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164816 (Take the colon span into account for struct field initializers)
 - #164836 (Add regression test for #162109)
 - #164846 (Remove contradictory inequalities from overflow safety docs)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164880 (Add context span showing item that can't be annotated)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
 - #164884 (Windows: bounds-check the reparse point name in `read_link`)
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Auto merge of #164894 - JonathanBrouwer:rollup-fyOlw75, r=JonathanBro…
7d0f9b4 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #160404 (fd-views: AsRef<File>&Co. for BorrowedFd)
 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #163769 (reborrow: Fix various ICEs related to auto reborrowing of user-space types)
 - #164764 (Test(lib/sync): Fix `test_rwlock_max_readers` for 32bit architectures)
 - #164860 (std::fs: read interrupted by a signal, read_buf_exact_at reports EOF.)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #163510 (process: Improve the output of `Debug` for `ExitStatus` on Unix)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164816 (Take the colon span into account for struct field initializers)
 - #164836 (Add regression test for #162109)
 - #164846 (Remove contradictory inequalities from overflow safety docs)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164880 (Add context span showing item that can't be annotated)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
 - #164884 (Windows: bounds-check the reparse point name in `read_link`)
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Unrolled build for #160404 in rollup 164894
1dd72d5 
Rollup merge of #160404 - the8472:fd-views, r=jhpratt

fd-views: AsRef<File>&Co. for BorrowedFd

tracking issue: #160402

This uses `#[unstable_feature_bound]` so the trait impls are _not_ insta-stable, so no FCP needed yet. But they're infectious to callers which means we currently can't dogfood the added API in std itself.
@rust-bors
rust-bors Bot merged commit fb20b7c into rust-lang:main Oct 25, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 25, 2026
@rust-timer

rust-timer commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (1dd72d5): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.0%, 0.5%] 12
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.8% [0.5%, 1.3%] 10
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [0.5%, 1.3%] 10

Cycles

Results (primary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.8% [0.4%, 1.8%] 5
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-1.4%, -0.5%] 8
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-1.4%, 1.8%] 13

Binary size

This perf run didn't have relevant results for this metric.

Artifact size: 405.87 MiB -> 405.96 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Oct 25, 2026
@JonathanBrouwer

JonathanBrouwer commented Oct 26, 2026

Copy link
Copy Markdown
Member

@rustbot label: +perf-regression-triaged
Noise

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@jhpratt jhpratt

Labels

O-unix Operating system: Unix-like O-windows Operating system: Windows perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

7 participants

@the8472 @rustbot @rust-log-analyzer @jhpratt @rust-timer @JonathanBrouwer @RalfJung