Rename `bstr` module/feature to `byte_str` by clarfonthey · Pull Request #160912 · rust-lang/rust

clarfonthey · 2026-08-11T13:57:06Z

This also renames the various features to use byte_str instead of bstr.

This was discussed by libs and agreed on as being more consistent with the types contained in the module. However, we remain open to renaming back before stabilization if warranted.

For now, byte_str::ByteStr makes the most sense.

(To be clear, bstr::ByteStr and byte_str::BStr are both undesired.)

rustbot · 2026-08-11T13:57:11Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, nia-e

theemathas · 2026-08-11T16:42:16Z

Can we also have a doc alias or something, so when someone searches for bstr (like the crate name), they also find this?

clarfonthey · 2026-08-11T17:02:22Z

Thank you for reminding me; I'll add those to the types and the module.

EDIT: The types already have it, so, just the module, then.

clarfonthey · 2026-08-11T18:26:09Z

Yeah, okay, since the types have this, adding it to the modules is just extra noise:

module bstr - see std::byte_str, struct BStr - see std::byte_str::ByteStr, module bstr - see alloc::byte_str, module bstr - see core::byte_str, struct BString - see std::byte_str::ByteString

clarfonthey · 2026-08-11T18:32:41Z

Note: the rustdoc links are annoying, but I'll finagle a fix for them.

Mark-Simulacrum · 2026-08-16T22:43:37Z

I assume there's a "why" somewhere for this, can you expand the PR description to include it? The actual code changes seem fine (I guess modulo CI failure :)

clarfonthey · 2026-10-03T01:19:19Z

Ugh, fine, I guess this isn't done. @rustbot author

:|

rustbot · 2026-10-03T01:19:24Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

clarfonthey · 2026-10-03T14:25:30Z

@rustbot ready

Mark-Simulacrum · 2026-10-03T20:40:12Z

I think #160912 (comment) is still unresolved -- this should have some motivation in the PR description :)

clarfonthey · 2026-10-03T21:20:56Z

Was this not sufficient?

#160912 (comment)

(Don't remember if you were there for the discussion)

Edit: you weren't, but here's the discussion: https://github.com/rust-lang/libs-team/blob/main/minutes/2026-08-25.md#nominated-rusttf160912-rename-bstr-modulefeature-to-byte_str

clarfonthey · 2026-10-15T13:08:48Z

ping @Mark-Simulacrum to take another look when you have time

Mark-Simulacrum · 2026-10-18T18:33:58Z

I updated the PR description so a future reader hopefully needs to hunt through less history to figure that out.

@bors r+

rust-bors · 2026-10-18T18:34:01Z

📌 Commit d124e88 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

rust-bors · 2026-10-18T19:38:54Z

⌛ Testing commit d124e88 with merge 5e6e3df...

Workflow: https://github.com/rust-lang/rust/actions/runs/39159724762

Rename `bstr` module/feature to `byte_str` This also renames the various features to use `byte_str` instead of `bstr`. This was [discussed](https://github.com/rust-lang/libs-team/blob/main/minutes/2026-08-25.md#nominated-rusttf160912-rename-bstr-modulefeature-to-byte_str) by libs and agreed on as being more consistent with the types contained in the module. However, we remain open to renaming back before stabilization if warranted. For now, `byte_str::ByteStr` makes the most sense. (To be clear, `bstr::ByteStr` and `byte_str::BStr` are both undesired.)

JonathanBrouwer · 2026-10-18T20:44:53Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-10-18T20:44:57Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/39159724762

The next pull request likely to be tested is #164535.

…uwer Rollup of 4 pull requests Successful merges: - #160912 (Rename `bstr` module/feature to `byte_str`) - #164463 (perf: inline `Clause::map_bound`) - #163746 (consteval: Rework caller location handling) - #163611 (add core::process::resumable_breakpoint)

Rollup merge of #160912 - clarfonthey:byte-str-module, r=Mark-Simulacrum Rename `bstr` module/feature to `byte_str` This also renames the various features to use `byte_str` instead of `bstr`. This was [discussed](https://github.com/rust-lang/libs-team/blob/main/minutes/2026-08-25.md#nominated-rusttf160912-rename-bstr-modulefeature-to-byte_str) by libs and agreed on as being more consistent with the types contained in the module. However, we remain open to renaming back before stabilization if warranted. For now, `byte_str::ByteStr` makes the most sense. (To be clear, `bstr::ByteStr` and `byte_str::BStr` are both undesired.)

…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#160912 (Rename `bstr` module/feature to `byte_str`) - rust-lang/rust#164463 (perf: inline `Clause::map_bound`) - rust-lang/rust#163746 (consteval: Rework caller location handling) - rust-lang/rust#163611 (add core::process::resumable_breakpoint)

rustbot assigned Mark-Simulacrum Aug 11, 2026

rustbot added O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-unix Operating system: Unix-like O-windows Operating system: Windows labels Aug 11, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2026

clarfonthey removed O-windows Operating system: Windows O-unix Operating system: Unix-like O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) labels Aug 11, 2026

clarfonthey force-pushed the byte-str-module branch from 4ad0fe2 to 149db1b Compare August 11, 2026 14:04

rustbot added O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) O-unix Operating system: Unix-like O-windows Operating system: Windows labels Aug 11, 2026