Also warn if an invalid `doc` attribute is used on a macro invocation by GuillaumeGomez · Pull Request #161003 · rust-lang/rust

GuillaumeGomez · 2026-08-12T19:39:50Z

So about this: I think the error message is good enough, but I can specialize it in case it's not a doc comment but a doc attribute.

Also: currently the ignored attributes are not kept in the AST, so when we reach rustc_attr_parsing, the attribute is not present and there won't trigger an error. I don't think it's worth changing this logic but in case someone thinks otherwise, it's mentioned. :)

r? @JonathanBrouwer

mejrs

r? me

so when we reach rustc_attr_parsing, the attribute is not present and there won't trigger an error. I don't think it's worth changing this logic but in case someone things otherwise, it's mentioned. :)

that's implemented in #160904, which does this (sort of) and also like three other things 🙈

I think this is a good step to merge first, makes ^ a bit simpler.

@bors r+ rollup

View changes since this review

rust-bors · 2026-08-12T21:41:24Z

📌 Commit a09d72a has been approved by mejrs

It is now in the queue for this repository.

GuillaumeGomez · 2026-08-12T21:42:45Z

@mejrs Nicely done!

@JonathanBrouwer

…c, r=mejrs Also warn if an invalid `doc` attribute is used on a macro invocation Fixes rust-lang#160880. So about this: I think the error message is good enough, but I can specialize it in case it's not a doc comment but a doc attribute. Also: currently the ignored attributes are not kept in the AST, so when we reach `rustc_attr_parsing`, the attribute is not present and there won't trigger an error. I don't think it's worth changing this logic but in case someone thinks otherwise, it's mentioned. :) r? @JonathanBrouwer

mejrs · 2026-08-12T23:34:32Z

Also just a note - I don't think this fixes #160880. I think we should FCW on that and later try a crater run and see if we can get away with erroring on it again.

Rollup of 13 pull requests Successful merges: - #160976 (Ensure TLS accesses don't call the global allocator through panic (part 2)) - #160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code) - #160985 (self-profile more of borrowck) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #159566 (Add support for generics in `offload`and remove `no_mangle` attribute) - #160676 (rustc_public: split `def`s out of `ty`) - #160861 (rustc_parse: suggest removing semicolon before `if` block) - #160958 (Remove unused `#[non_exhaustive]` in library) - #160978 (move resolve_path to Session inherent method) - #160990 (Remove old cfg parser which is now dead code) - #160991 (Add offload component on nightly) - #160999 (doc changes to expect messages in process.rs) - #161003 (Also warn if an invalid `doc` attribute is used on a macro invocation)

GuillaumeGomez · 2026-08-13T08:55:18Z

Replaced it with "part of" then.

@JonathanBrouwer

Rollup merge of #161003 - GuillaumeGomez:doc-attr-macro-invoc, r=mejrs Also warn if an invalid `doc` attribute is used on a macro invocation Fixes #160880. So about this: I think the error message is good enough, but I can specialize it in case it's not a doc comment but a doc attribute. Also: currently the ignored attributes are not kept in the AST, so when we reach `rustc_attr_parsing`, the attribute is not present and there won't trigger an error. I don't think it's worth changing this logic but in case someone thinks otherwise, it's mentioned. :) r? @JonathanBrouwer

rust-timer · 2026-08-18T10:00:53Z

Finished benchmarking commit (d80b7f1): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.642s -> 454.976s (-0.15%)
Artifact size: 396.40 MiB -> 396.36 MiB (-0.01%)

BoxyUwU · 2026-09-04T15:56:50Z

should this not have had sign off from some team either rustdoc or lang? 🤔

GuillaumeGomez · 2026-09-04T16:02:36Z

It was silently ignored before, now it's emitted as it should have from the start. It's a bugfix here, so I'm not sure if rustdoc should have signed off anything?

Rollup of 13 pull requests Successful merges: - rust-lang#160976 (Ensure TLS accesses don't call the global allocator through panic (part 2)) - rust-lang#160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code) - rust-lang#160985 (self-profile more of borrowck) - rust-lang#137858 (Add new `unused_footnote_definition` rustdoc lint) - rust-lang#159566 (Add support for generics in `offload`and remove `no_mangle` attribute) - rust-lang#160676 (rustc_public: split `def`s out of `ty`) - rust-lang#160861 (rustc_parse: suggest removing semicolon before `if` block) - rust-lang#160958 (Remove unused `#[non_exhaustive]` in library) - rust-lang#160978 (move resolve_path to Session inherent method) - rust-lang#160990 (Remove old cfg parser which is now dead code) - rust-lang#160991 (Add offload component on nightly) - rust-lang#160999 (doc changes to expect messages in process.rs) - rust-lang#161003 (Also warn if an invalid `doc` attribute is used on a macro invocation)

Rollup of 13 pull requests Successful merges: - rust-lang/rust#160976 (Ensure TLS accesses don't call the global allocator through panic (part 2)) - rust-lang/rust#160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code) - rust-lang/rust#160985 (self-profile more of borrowck) - rust-lang/rust#137858 (Add new `unused_footnote_definition` rustdoc lint) - rust-lang/rust#159566 (Add support for generics in `offload`and remove `no_mangle` attribute) - rust-lang/rust#160676 (rustc_public: split `def`s out of `ty`) - rust-lang/rust#160861 (rustc_parse: suggest removing semicolon before `if` block) - rust-lang/rust#160958 (Remove unused `#[non_exhaustive]` in library) - rust-lang/rust#160978 (move resolve_path to Session inherent method) - rust-lang/rust#160990 (Remove old cfg parser which is now dead code) - rust-lang/rust#160991 (Add offload component on nightly) - rust-lang/rust#160999 (doc changes to expect messages in process.rs) - rust-lang/rust#161003 (Also warn if an invalid `doc` attribute is used on a macro invocation)

Pkgsrc changes: * Adapt to changes in vendored crate versions. * Version & checksum changes. Upstream changes: Version 1.99.0 (2026-10-01) ========================== Language -------- - [Add allow-by-default `raw_borrows_via_references` lint that checks for references that decay immediately into raw borrows](rust-lang/rust#138230) - [Extend `unconditional_panic` lint to function calls that panic when the chunks/windows size is zero] (rust-lang/rust#153563) - [Stabilize C-variadic function definitions] (rust-lang/rust#155697) - [Stabilize the ability to use `#[unsafe(naked)]` functions to define C-variadic functions (`#![feature(c_variadic_naked_functions)]`).] (rust-lang/rust#159746) - [Trait methods are now resolved on an adjusted never type (producing a FCW)] (rust-lang/rust#156047) - [Coerce from inference variables to trait objects if the inference variable is related via subtyping to a type that is known to be `Sized`] (rust-lang/rust#157820) - [Stabilize `#[my_macro] mod foo;`] (rust-lang/rust#157857). This allows outlined modules (`mod foo;`) anywhere in the body of a custom attribute or derive macro. - [Fix the `overflowing_literals` lint with repeated negation] (rust-lang/rust#158302). For instance, it will now no longer lint on `--128_i8`, which is already detected by the `arithmetic_overflow` lint. - [Add POSIX symbols to the `invalid_runtime_symbol_definitions` and `suspicious_runtime_symbol_definitions` lints] (rust-lang/rust#158522) - [Lint unused `#[path]` attributes on inline modules] (rust-lang/rust#158835) - [Enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group] (rust-lang/rust#159179) - [Stabilize passing 128-bit integers via vector registers with `asm!` on x86] (rust-lang/rust#159525) - [Explicitly document that some allocations are allowed to grow in-place (but none are allowed to shrink)] (rust-lang/rust#159729) - We now [guarantee] (rust-lang/rust#159730) that the contents of an `UnsafeCell` can be accessed without going through `get` - [The `invalid_reference_casting` lint was adjusted accordingly] (rust-lang/rust#159960) - [Account for globally enabled target features in `global_asm!`] (rust-lang/rust#160594) - [Warn if an invalid `doc` attribute is used on a macro invocation] (rust-lang/rust#161003) Compiler -------- - [Convert `-Ctarget-cpu` into a target-modifier for AVR, AMDGCN and NVPTX] (rust-lang/rust#150732) - [Enable `static_position_independent_executables` on all gnu and musl targets] (rust-lang/rust#158510) - When providing a suggestion about a missing method, rustc now prefers an exactly matching name from a [doc alias attribute] (https://doc.rust-lang.org/rustdoc/advanced-features.html#add-aliases-for-an-item-in-documentation-search) over a similarity search from other method names. If your new users sometimes expect a method under a different name, adding a doc alias will now help them find it via rustc suggestions, in addition to helping them find it via rustdoc search: [When suggesting method names, prefer *exact* doc aliases over similar names](rust-lang/rust#160369) Platform Support ---------------- - [Promote `riscv64-unknown-linux-musl` to Tier 2 with host tools] (rust-lang/rust#158766) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. [platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html Libraries --------- - Iteration on `RangeInclusive` (`a..=b` ranges) is now [optimized better in some circumstances] (rust-lang/rust#155114). As a side effect of this, the behavior of `RangeInclusive` values that has already been exhausted (as an iterator) has changed. For example, the return values of `start()` and `end()` on such ranges may return different values, and using such ranges as slice indexes may have different behavior. These behaviors were not guaranteed to be stable, so these changes are considered to not be breaking changes. - [Relax `transmute_copy` to accept `?Sized` types] (rust-lang/rust#155989) - [Update `transmute_copy` to use a non-unwinding panic] (rust-lang/rust#155989) - [Don't escape U+FF9E and U+FF9F in `escape_debug_ext`] (rust-lang/rust#158057) - [Re-export `core::fmt::NumBuffer` in `alloc` (and `std`)] (rust-lang/rust#161430) Stabilized APIs --------------- - [`IntoIterator` for `Box<[T; N]>`] (https://doc.rust-lang.org/stable/std/iter/trait.IntoIterator.html#impl-IntoIterator-for-Box%3C%5BT;+N%5D,+A%3E) - [`IntoIterator` for `&Box<[T; N]>`] (https://doc.rust-lang.org/stable/std/iter/trait.IntoIterator.html#impl-IntoIterator-for-%26Box%3C%5BT;+N%5D,+A%3E) - [`IntoIterator` for `&mut Box<[T; N]>`] (https://doc.rust-lang.org/stable/std/iter/trait.IntoIterator.html#impl-IntoIterator-for-%26mut+Box%3C%5BT;+N%5D,+A%3E) - [`VecDeque::retain_back`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.retain_back) - [`core::ffi::VaList`] (https://doc.rust-lang.org/stable/core/ffi/struct.VaList.html) - [`Box::into_non_null`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_non_null) - [`Box::from_non_null`] (https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.from_non_null) - [`Vec::into_parts`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.into_parts) - [`Vec::from_parts`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.from_parts) - [`core::mem::size_of_val_raw`] (https://doc.rust-lang.org/stable/core/mem/fn.size_of_val_raw.html) - [`core::mem::align_of_val_raw`] (https://doc.rust-lang.org/stable/core/mem/fn.align_of_val_raw.html) - [`core::alloc::Layout::for_value_raw`] (https://doc.rust-lang.org/stable/core/alloc/struct.Layout.html#method.for_value_raw) - [`String::from_utf8_lossy_owned`] (https://doc.rust-lang.org/stable/std/string/struct.String.html#method.from_utf8_lossy_owned) - [`string::FromUtf8Error::into_utf8_lossy`] (https://doc.rust-lang.org/stable/std/string/struct.FromUtf8Error.html#method.into_utf8_lossy) - [`FusedIterator for StepBy<I>`] (https://doc.rust-lang.org/stable/std/iter/struct.StepBy.html#impl-FusedIterator-for-StepBy%3CI%3E) - [`std::fs::set_times`] (https://doc.rust-lang.org/stable/std/fs/fn.set_times.html) - [`std::fs::set_times_nofollow`] (https://doc.rust-lang.org/stable/std/fs/fn.set_times_nofollow.html) Cargo ----- - Add a new built-in profile `debug`. This is a preparation for transitioning the `dev` profile away from debugging to give a saner default for faster development iterations. Currently there is no difference between `dev` and `debug` profiles. [docs] (https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#debug-1) [#17214] (rust-lang/cargo#17214) - Workspace members on edition 2024 or later can now override an inherited workspace dependency's `default-features` field. For example, `serde = { workspace = true, default-features = false }` now turns off default features even when the workspace definition enables them. On earlier editions, `default-features = false` is ignored with a warning. ([RFC 3945] (rust-lang/rfcs#3945)) [#17126](rust-lang/cargo#17126) - Incremental compilation is now disabled by default when running in CI. CI is detected via the CI environment variable. [#17220] (rust-lang/cargo#17220) See also the [full Cargo changelog] (https://doc.rust-lang.org/nightly/cargo/CHANGELOG.html#cargo-199-2026-10-01) Rustdoc ----- - [Add new `unused_footnote_definition` rustdoc lint] (rust-lang/rust#137858) - Smarter filtering of trait impls yields performance improvements of 20% on average and up to 40% on some real-world crates. ([1] (rust-lang/rust#159623), [2](rust-lang/rust#159721), [3](rust-lang/rust#159779), [4](rust-lang/rust#159854), [5](rust-lang/rust#159091)) Compatibility Notes ------------------- - [Fully deprecate the legacy integral modules] (rust-lang/rust#146882). For example, `std::i32::MAX` should be accessed via `i32::MAX` instead. - [Upgrade `no_mangle_generic_items` into hard error] (rust-lang/rust#154585) - [The `Pin::new_unchecked` has had its safety invariants changed slightly] (rust-lang/rust#156935) - [Do not promote references to extern statics] (rust-lang/rust#157641) - [Ensure that the inferred types of `let` patterns typecheck] (rust-lang/rust#157841) - [hermit/fs: Return `unsupported()` instead of `from_raw_os_error(22)`] (rust-lang/rust#158247) - [Fixed a bug where `#[repr(simd)]` was accidentally allowed on macro invocations on stable Rust] (rust-lang/rust#158523) - [Abort const-eval when there are generics in the type of the value being produced] (rust-lang/rust#159504) - [Attributes not applying to anything are now an error in code blocks in doc comments] (rust-lang/rust#159849) - [`Box::leak`: tell people to avoid unleaking] (rust-lang/rust#160323) - [PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian] (rust-lang/rust#160441) - [Do not take `doc(cfg())` into account when filtering doctests] (rust-lang/rust#159014) - [Infer anonymous lifetimes in the types of associated consts as `'static`] (rust-lang/rust#156508) - Macros that expand to a semicolon now produce a warning lint (`semicolon_in_expressions_from_non_local_macros`) even when the macro comes from another crate. Previously, such warnings only appeared for macros from the same crate, to avoid showing warnings that can't be fixed locally; however, this masked problems, as integration tests from the crate providing the macro get compiled as a separate crate, so tests often wouldn't reveal this issue. If you encounter a lint like this, please make sure to report it to the crate providing the macro so they can fix it; don't just silence it in your own crate. - [`semicolon_in_expressions_from_macros`: Lint on non-local macros too] (rust-lang/rust#159222) - [Split non-local `semicolon_in_expressions_from_macros` into a separate lint] (rust-lang/rust#159700) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Update to LLVM 23] (rust-lang/rust#158734)

Also warn if an invalid doc attribute is used on a macro invocation

a09d72a

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 12, 2026

rustbot assigned JonathanBrouwer Aug 12, 2026

mejrs approved these changes Aug 12, 2026

View reviewed changes

rustbot assigned mejrs Aug 12, 2026

rustbot unassigned JonathanBrouwer Aug 12, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026

GuillaumeGomez mentioned this pull request Aug 12, 2026

Rollup of 8 pull requests #161008

Closed

jhpratt mentioned this pull request Aug 13, 2026

Rollup of 13 pull requests #161014

Merged

rust-bors Bot merged commit f5196ef into rust-lang:main Aug 13, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 13, 2026

GuillaumeGomez deleted the doc-attr-macro-invoc branch August 13, 2026 10:26

mejrs mentioned this pull request Aug 13, 2026

doc attributes on macro invocations can contain arbitrary expressions #160880

Open

BoxyUwU added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 28, 2026

rustbot mentioned this pull request Aug 28, 2026

Tracking issue for release notes of #161003: Also warn if an invalid doc attribute is used on a macro invocation #161918

Closed

BoxyUwU mentioned this pull request Sep 4, 2026

Draft release notes for 1.99.0 #162306

Closed

Navigation Menu

Repository navigation

Also warn if an invalid `doc` attribute is used on a macro invocation - #161003

Also warn if an invalid `doc` attribute is used on a macro invocation#161003
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:doc-attr-macro-invoc

GuillaumeGomez commented Aug 12, 2026 •

edited

Loading

Uh oh!

mejrs left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Aug 12, 2026

Uh oh!

GuillaumeGomez commented Aug 12, 2026

Uh oh!

mejrs commented Aug 12, 2026

Uh oh!

GuillaumeGomez commented Aug 13, 2026

Uh oh!

Uh oh!

rust-timer commented Aug 18, 2026

Uh oh!

BoxyUwU commented Sep 4, 2026

Uh oh!

GuillaumeGomez commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

GuillaumeGomez commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 12, 2026

Uh oh!

GuillaumeGomez commented Aug 12, 2026

Uh oh!

mejrs commented Aug 12, 2026

Uh oh!

GuillaumeGomez commented Aug 13, 2026

Uh oh!

Uh oh!

rust-timer commented Aug 18, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

BoxyUwU commented Sep 4, 2026

Uh oh!

GuillaumeGomez commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GuillaumeGomez commented Aug 12, 2026 •

edited

Loading

mejrs left a comment •

edited by rustbot

Loading