Stabilize `Result::into_{ok,err}` by theemathas · Pull Request #161712 · rust-lang/rust

theemathas · 2026-08-25T00:29:02Z

Tracking issue: #61695

As evidence of the demand of this API, here are some instances of people having written functions for this functionality:

API being stabilized:

impl<T, E> Result<T, E> {
    pub fn into_ok(self) -> T
    where
        E: Into<!>
    { .... }
    pub fn into_err(self) -> E
    where
        T: Into<!>,
    { .... }
}

Implementation history: (I'm including only ones that touches the public API being stabilized, and not documentation or constification)

rustbot · 2026-08-25T00:29:06Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

rustbot · 2026-08-25T00:29:08Z

r? @nia-e

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

nia-e · 2026-08-25T15:44:18Z

@rfcbot fcp merge libs

rust-rfcbot · 2026-08-25T15:44:21Z

@nia-e has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rust-rfcbot · 2026-09-15T19:04:12Z

🔔 This is now entering its final comment period, as per the review above. 🔔

Tracking issue: rust-lang#61695

rustbot · 2026-09-24T13:35:13Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rust-rfcbot · 2026-09-25T19:08:07Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

nia-e · 2026-09-28T16:27:05Z

@bors r+

rust-bors · 2026-09-28T16:27:08Z

📌 Commit f3b4f0f has been approved by nia-e

It is now in the queue for this repository.

Stabilize `Result::into_{ok,err}` Tracking issue: rust-lang#61695 --- As evidence of the demand of this API, here are some instances of people having written functions for this functionality: * https://github.com/meteroid-oss/meteroid/blob/6cc14c4a444c6ae4889c603f5cb275ea626d7507/crates/common-utils/src/misc.rs#L7 * https://github.com/mokeyish/smartdns-rs/blob/788e83fa72477ebcf1c6a7f4482359353d29c480/src/server/http.rs#L93 * https://github.com/nostrdevkit/nostr/blob/ea38c0e3b2fc2717a4a55d019560a5574baf8cd0/nostr/src/util/mod.rs#L120 * https://github.com/ngrok/ngrok-rust/blob/3d5131559948ba9932dd0a450474fd1d19d206eb/ngrok/examples/tls.rs#L92 * https://github.com/octopii-rs/octopii/blob/b54c112d7db7ed1195dd4f600b4b786df85c8e7e/openraft/openraft/src/error/into_ok.rs#L10 * https://github.com/TeXitoi/keyseebee/blob/30956f62e618ed754c15af66f8ade70269fef89a/firmware/src/main.rs#L54 --- API being stabilized: ```rust impl<T, E> Result<T, E> { pub fn into_ok(self) -> T where E: Into<!> { .... } pub fn into_err(self) -> E where T: Into<!>, { .... } } ``` --- Implementation history: (I'm including only ones that touches the public API being stabilized, and not documentation or constification) * rust-lang/rfcs#2799 * rust-lang#66045 * rust-lang#83421 * rust-lang#92444

…uwer Rollup of 15 pull requests Successful merges: - #158936 (Add `std::fs::{Home|Media}Dirs`) - #129036 (Additional NonZero conversions) - #158997 (Avoid recording unnameable `extern crate` aliases in diagnostic metadata) - #161015 (Stabilize `funnel_shifts` (including `const`)) - #161712 (Stabilize `Result::into_{ok,err}`) - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #162655 (next solver: prefer to select impl candidates over global where-clause candidates) - #162862 (Fix intra doc link resolution when a doc comment is composed of both inner and outer doc comment) - #163200 (make `RustaceansAreAwesome` satisfy trait bounds) - #163331 (Move `Arc` and `Rc` into `rcs` mod) - #163427 (implement #![feature(gca_adts)]) - #163428 (do not complain about unstable target features on nightly) - #163444 (Add `stable_rustc` helper in `run-make-support`) - #163447 (Allow using different index types when reading and writing to tables) - #163450 (Force the correct type variable to never for method resolution on an adjusted never type)

Stabilize `Result::into_{ok,err}` Tracking issue: rust-lang#61695 --- As evidence of the demand of this API, here are some instances of people having written functions for this functionality: * https://github.com/meteroid-oss/meteroid/blob/6cc14c4a444c6ae4889c603f5cb275ea626d7507/crates/common-utils/src/misc.rs#L7 * https://github.com/mokeyish/smartdns-rs/blob/788e83fa72477ebcf1c6a7f4482359353d29c480/src/server/http.rs#L93 * https://github.com/nostrdevkit/nostr/blob/ea38c0e3b2fc2717a4a55d019560a5574baf8cd0/nostr/src/util/mod.rs#L120 * https://github.com/ngrok/ngrok-rust/blob/3d5131559948ba9932dd0a450474fd1d19d206eb/ngrok/examples/tls.rs#L92 * https://github.com/octopii-rs/octopii/blob/b54c112d7db7ed1195dd4f600b4b786df85c8e7e/openraft/openraft/src/error/into_ok.rs#L10 * https://github.com/TeXitoi/keyseebee/blob/30956f62e618ed754c15af66f8ade70269fef89a/firmware/src/main.rs#L54 --- API being stabilized: ```rust impl<T, E> Result<T, E> { pub fn into_ok(self) -> T where E: Into<!> { .... } pub fn into_err(self) -> E where T: Into<!>, { .... } } ``` --- Implementation history: (I'm including only ones that touches the public API being stabilized, and not documentation or constification) * rust-lang/rfcs#2799 * rust-lang#66045 * rust-lang#83421 * rust-lang#92444

Rollup of 9 pull requests Successful merges: - #161015 (Stabilize `funnel_shifts` (including `const`)) - #161712 (Stabilize `Result::into_{ok,err}`) - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #163427 (implement #![feature(gca_adts)]) - #163390 (add `automatically_derived` attribute documentation) - #163428 (do not complain about unstable target features on nightly) - #163444 (Add `stable_rustc` helper in `run-make-support`) - #163447 (Allow using different index types when reading and writing to tables) - #163459 (Stabilize vec_try_remove)

Rollup of 9 pull requests Successful merges: - rust-lang/rust#161015 (Stabilize `funnel_shifts` (including `const`)) - rust-lang/rust#161712 (Stabilize `Result::into_{ok,err}`) - rust-lang/rust#162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - rust-lang/rust#163427 (implement #![feature(gca_adts)]) - rust-lang/rust#163390 (add `automatically_derived` attribute documentation) - rust-lang/rust#163428 (do not complain about unstable target features on nightly) - rust-lang/rust#163444 (Add `stable_rustc` helper in `run-make-support`) - rust-lang/rust#163447 (Allow using different index types when reading and writing to tables) - rust-lang/rust#163459 (Stabilize vec_try_remove)

Stabilize `Result::into_{ok,err}` Tracking issue: rust-lang#61695 --- As evidence of the demand of this API, here are some instances of people having written functions for this functionality: * https://github.com/meteroid-oss/meteroid/blob/6cc14c4a444c6ae4889c603f5cb275ea626d7507/crates/common-utils/src/misc.rs#L7 * https://github.com/mokeyish/smartdns-rs/blob/788e83fa72477ebcf1c6a7f4482359353d29c480/src/server/http.rs#L93 * https://github.com/nostrdevkit/nostr/blob/ea38c0e3b2fc2717a4a55d019560a5574baf8cd0/nostr/src/util/mod.rs#L120 * https://github.com/ngrok/ngrok-rust/blob/3d5131559948ba9932dd0a450474fd1d19d206eb/ngrok/examples/tls.rs#L92 * https://github.com/octopii-rs/octopii/blob/b54c112d7db7ed1195dd4f600b4b786df85c8e7e/openraft/openraft/src/error/into_ok.rs#L10 * https://github.com/TeXitoi/keyseebee/blob/30956f62e618ed754c15af66f8ade70269fef89a/firmware/src/main.rs#L54 --- API being stabilized: ```rust impl<T, E> Result<T, E> { pub fn into_ok(self) -> T where E: Into<!> { .... } pub fn into_err(self) -> E where T: Into<!>, { .... } } ``` --- Implementation history: (I'm including only ones that touches the public API being stabilized, and not documentation or constification) * rust-lang/rfcs#2799 * rust-lang#66045 * rust-lang#83421 * rust-lang#92444

theemathas added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 25, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Aug 25, 2026

rustbot assigned nia-e Aug 25, 2026

This comment has been minimized.

Sign in to view

theemathas force-pushed the stab-into-ok-err branch from bf72f16 to beda5e0 Compare August 25, 2026 01:22

This comment has been minimized.

Sign in to view

theemathas force-pushed the stab-into-ok-err branch from beda5e0 to b9a4841 Compare August 29, 2026 13:10

This comment has been minimized.

Sign in to view

rust-rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Sep 15, 2026

rust-rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Sep 15, 2026

This comment has been minimized.

Sign in to view

Stabilize Result::into_{ok,err}

f3b4f0f

Tracking issue: rust-lang#61695

theemathas force-pushed the stab-into-ok-err branch from b9a4841 to f3b4f0f Compare September 24, 2026 13:35

rustbot mentioned this pull request Sep 25, 2026

Tracking issue for release notes of #161712: Stabilize Result::into_{ok,err} #163350

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2026

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 12 pull requests #163456

Closed

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 15 pull requests #163460

Closed

tgross35 mentioned this pull request Sep 29, 2026

Rollup of 9 pull requests #163465

Merged

tgross35 mentioned this pull request Sep 29, 2026

Rollup of 9 pull requests #163467

Closed

rust-bors Bot merged commit 4426dcd into rust-lang:main Sep 29, 2026
13 checks passed

rustbot added this to the 1.101.0 milestone Sep 29, 2026

theemathas deleted the stab-into-ok-err branch September 29, 2026 07:24

github-actions Bot mentioned this pull request Oct 3, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

theemathas mentioned this pull request Oct 4, 2026

Tracking issue for Result::into_ok #61695

Closed

Navigation Menu

Repository navigation

Stabilize `Result::into_{ok,err}` - #161712

Stabilize `Result::into_{ok,err}`#161712
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
theemathas:stab-into-ok-err

theemathas commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

nia-e commented Aug 25, 2026

Uh oh!

rust-rfcbot commented Aug 25, 2026 •

edited by BurntSushi

Loading

Uh oh!

This comment has been minimized.

rust-rfcbot commented Sep 15, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 24, 2026

Uh oh!

rust-rfcbot commented Sep 25, 2026

Uh oh!

nia-e commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

theemathas commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

rustbot commented Aug 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

nia-e commented Aug 25, 2026

Uh oh!

rust-rfcbot commented Aug 25, 2026 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-rfcbot commented Sep 15, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 24, 2026

Uh oh!

rust-rfcbot commented Sep 25, 2026

Uh oh!

nia-e commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rust-rfcbot commented Aug 25, 2026 •

edited by BurntSushi

Loading