Skip to content

rustdoc: Fix rendering of cross-crate target_features - #162208

Open
Cyberhet wants to merge 1 commit into
rust-lang:mainfrom
Cyberhet:fix-rustdoc-cross-crate-target-feature
Open

Cyberhet wants to merge 1 commit into
rust-lang:mainfrom
Cyberhet:fix-rustdoc-cross-crate-target-feature

Conversation

@Cyberhet

@Cyberhet Cyberhet commented Sep 2, 2026 •

Copy link
Copy Markdown

Fixes #162207

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 2, 2026
@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @notriddle (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 8 candidates
  • Random selection from GuillaumeGomez, camelid, lolbinarycat, notriddle

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Cyberhet
Cyberhet force-pushed the fix-rustdoc-cross-crate-target-feature branch from 8677c5e to 7c4c8b3 Compare September 2, 2026 19:08
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@fmease fmease assigned fmease and unassigned notriddle Sep 2, 2026
@rust-bors

This comment has been minimized.

@Cyberhet
Cyberhet force-pushed the fix-rustdoc-cross-crate-target-feature branch from 7c4c8b3 to b3cbc09 Compare September 28, 2026 04:17
@rustbot

rustbot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@Cyberhet
Cyberhet force-pushed the fix-rustdoc-cross-crate-target-feature branch from b3cbc09 to 1d2cf4f Compare September 28, 2026 04:18

@Cyberhet Cyberhet left a comment •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes to be made

View changes since this review

@notriddle

Copy link
Copy Markdown
Contributor

@bors r+

Thanks a bunch for fixing this problem!

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1d2cf4f has been approved by notriddle

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026
@notriddle

Copy link
Copy Markdown
Contributor

@bors r-

Wait, hold on. My mistake. I didn't realize you'd reassigned it, @fmease.

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 7, 2026
@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 7, 2026
@fmease

fmease commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Yes, I fear there are some non-trivialities that's why I ended up creating the linked GH issue instead of submitting a PR myself. I didn't have the time at that time to more deeply analyze various interactions & edge cases.

@fmease fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 14, 2026
@fmease fmease added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc drops inlined cross-crate re-exported #[target_feature(enable = "…")] from "cfg badge"

5 participants