Skip to content

Test #[track_caller] in async on gcc backend - #163262

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
theemathas:async-panic-track-caller-gcc-tests
Oct 19, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
theemathas:async-panic-track-caller-gcc-tests

Conversation

@theemathas

Copy link
Copy Markdown
Contributor

Previously, in #161972, this test was skipped on gcc, due to a bug in rustc_codegen_gcc. The bug was fixed by the subtree update at #162499.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 24, 2026
@theemathas
theemathas marked this pull request as ready for review September 24, 2026 15:04
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2026
@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 24, 2026
@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 20 candidates

Comment thread tests/ui/async-await/track-caller/panic-track-caller.rs
@theemathas
theemathas force-pushed the async-panic-track-caller-gcc-tests branch 2 times, most recently from 657d87c to 4f8c49f Compare September 27, 2026 09:41
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@theemathas
theemathas force-pushed the async-panic-track-caller-gcc-tests branch from b7503bd to 7631728 Compare October 2, 2026 15:02
@rustbot

This comment has been minimized.

@theemathas

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rustbot rustbot assigned jackh726 and unassigned davidtwco Oct 8, 2026
Previously, in rust-lang#161972,
this test was skipped on gcc, due to a bug in rustc_codegen_gcc.
The bug was fixed by the subtree update at
rust-lang#162499.
@theemathas
theemathas force-pushed the async-panic-track-caller-gcc-tests branch from 7631728 to 236daa7 Compare October 19, 2026 02:21
@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@RalfJung

Copy link
Copy Markdown
Member

@GuillaumeGomez or @antoyo would probably be the most suited reviewer here.

@GuillaumeGomez

Copy link
Copy Markdown
Member

If test is passing, I think it's safe to assume it works.

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 236daa7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 19, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #164562 (`rust-analyzer` subtree update)
 - #164369 (Make tuple `PartialOrd` chaining easier on mir-opt)
 - #163262 (Test `#[track_caller]` in async on gcc backend)
 - #164346 (avoid exporting non-instantiable mono items)
 - #164505 (Re-enable parallelism for coroutine_by_move_body_def_id)
@rust-bors
rust-bors Bot merged commit eba048a into rust-lang:main Oct 19, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 19, 2026
Rollup merge of #163262 - theemathas:async-panic-track-caller-gcc-tests, r=GuillaumeGomez

Test `#[track_caller]` in async on gcc backend

Previously, in #161972, this test was skipped on gcc, due to a bug in `rustc_codegen_gcc`. The bug was fixed by the subtree update at #162499.
@theemathas
theemathas deleted the async-panic-track-caller-gcc-tests branch October 19, 2026 16:49
WhySoBad pushed a commit to WhySoBad/miri that referenced this pull request Oct 20, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#164562 (`rust-analyzer` subtree update)
 - rust-lang/rust#164369 (Make tuple `PartialOrd` chaining easier on mir-opt)
 - rust-lang/rust#163262 (Test `#[track_caller]` in async on gcc backend)
 - rust-lang/rust#164346 (avoid exporting non-instantiable mono items)
 - rust-lang/rust#164505 (Re-enable parallelism for coroutine_by_move_body_def_id)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants