Conversation
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
r? libs |
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 1, 2026 02:25
557140b to
854e087
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 1, 2026 03:03
854e087 to
f9ee87d
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 1, 2026 04:01
f9ee87d to
a39b690
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
My scratch space for seeing what the various arches do https://rust.godbolt.org/z/Gs9jKPG7x |
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 1, 2026 05:27
a39b690 to
70d4713
Compare
Member
Author
|
@bors try jobs=test-x86_64-gnu-nopt,test-various,test-x86_64-gnu-llvm-22-* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
core: Add examples and assembly tests for `abort_immediate` try-job: test-x86_64-gnu-nopt try-job: test-various try-job: test-x86_64-gnu-llvm-22-*
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 1, 2026 18:48
70d4713 to
9f595d3
Compare
Member
Author
|
@bors try jobs=test-x86_64-gnu-nopt,test-various,test-x86_64-gnu-llvm-22-* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
core: Add examples and assembly tests for `abort_immediate` try-job: test-x86_64-gnu-nopt try-job: test-various try-job: test-x86_64-gnu-llvm-22-*
Contributor
2 of 7 tasks
This comment has been minimized.
This comment has been minimized.
We can reuse the test setup for other intrinsics, saving a bit of build time and repeated setup.
This isn't the most complicated function, but it currently isn't used anywhere in-tree (typically `intrinsics::abort` is used instead) and there are no examples or tests. Copy the examples from `abort` since this should behave similarly, and also cover it in an assembly test. We don't really need the assembly check for any guarantees but it is handy to reference what the intrinsic actually does, and will let us know if anything changes. I also added tests for `breakpoint` on more platforms since these were easy to do together.
tgross35
force-pushed
the
abort-immediate-update
branch
from
October 2, 2026 19:25
4de6e3a to
572ebd3
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't the most complicated function, but it currently isn't used
anywhere in-tree (typically
intrinsics::abortis used instead) andthere are no examples or tests. Copy the examples from
abortsincethis should behave similarly, and also cover it in an assembly test. We
don't really need the assembly check for any guarantees but it is handy
to reference what the intrinsic actually does, and will let us know if
anything changes.
I also added tests for
breakpointon more platforms since these wereeasy to do together.
Tracking issue: #154601