Skip to content

ctfe: Constify the abort intrinsic - #163579

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
tgross35:const-intrinsic-abort
Oct 2, 2026
Merged

ctfe: Constify the abort intrinsic#163579
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
tgross35:const-intrinsic-abort

Conversation

@tgross35

@tgross35 tgross35 commented Oct 1, 2026

Copy link
Copy Markdown
Member

This is a well-defined operation that we want to make use of in std/core, such as with abort_immediate.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 1, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
tgross35 force-pushed the const-intrinsic-abort branch 2 times, most recently from c9b0bcd to a376aa8 Compare October 1, 2026 18:43
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
tgross35 force-pushed the const-intrinsic-abort branch from a376aa8 to 892bd68 Compare October 1, 2026 19:44
@tgross35
tgross35 marked this pull request as ready for review October 1, 2026 19:46
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2026
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 20 candidates

@tgross35
ctfe: Constify the abort intrinsic
b923d1e 
This is a well-defined operation that we want to make use of in
std/core, such as with `abort_immediate`.
@tgross35
tgross35 force-pushed the const-intrinsic-abort branch from 892bd68 to b923d1e Compare October 1, 2026 19:47
@tgross35

tgross35 commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Cc @RalfJung who suggested this way of doing things at #miri > Stopping the machine from CTFE vs. Miri @ 💬

@tgross35 tgross35 mentioned this pull request Oct 1, 2026
Merged
@RalfJung

RalfJung commented Oct 1, 2026

Copy link
Copy Markdown
Member

LGTM, thanks!

@bors r+

@rust-bors

rust-bors Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b923d1e has been tentatively approved by RalfJung

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2026
@tgross35

tgross35 commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@bors r-

Since you've approved this and #163621 is stacked on this and got an approval, I think that one may as well be the one to merge to save a bors cycle.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2026
@rust-bors

rust-bors Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors
rust-bors Bot merged commit b923d1e into rust-lang:main Oct 2, 2026
14 checks passed
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 2, 2026
@rustbot rustbot added this to the 1.101.0 milestone Oct 2, 2026
@tgross35
tgross35 deleted the const-intrinsic-abort branch October 2, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tgross35 @rust-log-analyzer @rustbot @RalfJung @jackh726