Skip to content

Next-solver do not prefer trivially true candidates - #163589

Closed
lcnr wants to merge 1 commit into
rust-lang:mainfrom
lcnr:no-trivially-true-candidate
Closed

lcnr wants to merge 1 commit into
rust-lang:mainfrom
lcnr:no-trivially-true-candidate

Conversation

@lcnr

@lcnr lcnr commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

closed in favor of #163928

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 1, 2026
@rust-bors

This comment has been minimized.

@lcnr
lcnr force-pushed the no-trivially-true-candidate branch from 9d2a7c8 to 15e4db2 Compare October 2, 2026 08:17
@@ -1,44 +0,0 @@
//@ compile-flags: -Znext-solver

@lcnr lcnr Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better tested by https://github.com/lcnr/search_graph_fuzz anyways, having subtle cycle handling tests as ui tests is very brittle

View changes since the review

@rust-log-analyzer

This comment has been minimized.

@lcnr
lcnr force-pushed the no-trivially-true-candidate branch from 15e4db2 to c534566 Compare October 2, 2026 09:22
@lcnr
lcnr force-pushed the no-trivially-true-candidate branch from c534566 to ead6920 Compare October 7, 2026 07:01
@lcnr lcnr closed this Oct 7, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants