Repository navigation
std: simplify the miri bypass of the stack overflow detection logic - #163743
Merged
Merged
Conversation
Collaborator
|
Any special-casing of Miri in the standard library requires review. cc @rust-lang/miri |
rustbot
added
O-unix
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
miri_bypass_stack_overflow
branch
from
October 4, 2026 11:16
bd5d0fe to
a429208
Compare
RalfJung
reviewed
Oct 10, 2026
Comment on lines
+71
to
73
| if cfg!(miri) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Isn't the existing handler already required to be sound on a null pointer? Why does Miri need a special check?
Member
Author
There was a problem hiding this comment.
drop_handler unconditionally accesses the thread information BTreeMap, which means there is some extra synchronisation – enough to make some miri tests fail.
| make_handler(false) | ||
| if cfg!(miri) { | ||
| return Handler::null(); | ||
| } |
Member
There was a problem hiding this comment.
A comment similar to above would be good.
joboet
force-pushed
the
miri_bypass_stack_overflow
branch
from
October 11, 2026 09:26
a429208 to
cdd050c
Compare
RalfJung
approved these changes
Oct 11, 2026
Member
|
Looks good to me too r? ChrisDenton |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
…uwer Rollup of 9 pull requests Successful merges: - #163743 (std: simplify the miri bypass of the stack overflow detection logic) - #164474 (core: implement `char::is_xid_{start|continue}`) - #164643 (Const-stabilize `{BinaryHeap, BTreeMap, BTreeSet, LinkedList, VecDeque)::{len, is_empty}`) - #164739 (Use cfi_encoding instead of name in abi checking in miri) - #162927 (stabilize ptr_cast_slice) - #163372 (Restrict `PartialEq` and `PartialOrd` documentation to thin pointers) - #164261 (Simplify MSYS check in is_terminal on Windows) - #164698 (Remove FCP from libs tracking checklist) - #164810 (Don't prioritize issues that require internal features)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
Rollup merge of #163743 - joboet:miri_bypass_stack_overflow, r=ChrisDenton std: simplify the miri bypass of the stack overflow detection logic This is split out from #162296. Using `cfg!(miri)` instead of compile-time configuration avoids creating warnings about unused imports. And by creating a `init` function in the main module, there's space to put further shared logic. This would disable the stack overflow logic when running Cygwin targets under miri, but Cygwin isn't supported by miri anyhow.
programskillforverification
pushed a commit
to programskillforverification/miri
that referenced
this pull request
Oct 24, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#163743 (std: simplify the miri bypass of the stack overflow detection logic) - rust-lang/rust#164474 (core: implement `char::is_xid_{start|continue}`) - rust-lang/rust#164643 (Const-stabilize `{BinaryHeap, BTreeMap, BTreeSet, LinkedList, VecDeque)::{len, is_empty}`) - rust-lang/rust#164739 (Use cfi_encoding instead of name in abi checking in miri) - rust-lang/rust#162927 (stabilize ptr_cast_slice) - rust-lang/rust#163372 (Restrict `PartialEq` and `PartialOrd` documentation to thin pointers) - rust-lang/rust#164261 (Simplify MSYS check in is_terminal on Windows) - rust-lang/rust#164698 (Remove FCP from libs tracking checklist) - rust-lang/rust#164810 (Don't prioritize issues that require internal features)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split out from #162296. Using
cfg!(miri)instead of compile-time configuration avoids creating warnings about unused imports. And by creating ainitfunction in the main module, there's space to put further shared logic.This would disable the stack overflow logic when running Cygwin targets under miri, but Cygwin isn't supported by miri anyhow.