Skip to content

implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N] - #163753

Open
clarfonthey wants to merge 1 commit into
rust-lang:mainfrom
clarfonthey:revert-revert
Open

clarfonthey wants to merge 1 commit into
rust-lang:mainfrom
clarfonthey:revert-revert

Conversation

@clarfonthey

@clarfonthey clarfonthey commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

r? libs

This re-commits #152972 but in a way where we can actually do FCP. It was reverted in #163752.

API stabilization:

impl<T, U, A> PartialEq<VecDeque<U, A>> for Vec<T, A>;
impl<T, U, A> PartialEq<VecDeque<U, A>> for &[T];
impl<T, U, A> PartialEq<VecDeque<U, A>> for &mut [T];
impl<T, U, A, const N: usize> PartialEq<VecDeque<U, A>> for [T; N];
impl<T, U, A, const N: usize> PartialEq<VecDeque<U, A>> for &[T; N];
impl<T, U, A, const N: usize> PartialEq<VecDeque<U, A>> for &mut [T; N];

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor Author

@rfcbot merge libs

@rust-rfcbot rust-rfcbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 4, 2026
@rust-rfcbot

rust-rfcbot commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

@clarfonthey has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/libs-ping: FCP proposed for libs, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 4, 2026
… [T; N], &[T; N] and &mut [T; N]"

This reverts commit df0599e.
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants