Skip to content

Fix the floating point clobbers of RISC-V clobber_abi - #163839

Open
beetrees wants to merge 1 commit into
rust-lang:mainfrom
beetrees:fix-riscv-clobber-abi-fd
Open

beetrees wants to merge 1 commit into
rust-lang:mainfrom
beetrees:fix-riscv-clobber-abi-fd

Conversation

@beetrees

@beetrees beetrees commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

On RISC-V, callee-saved floating point registers are only callee-saved up to ABI_FLEN bits; the rest of the register is considered temporary. For clobber_abi("C"), as LLVM doesn't support partial register clobbers, this requires the callee-saved floating point registers to be clobbered.

These issues are noticeable in beta but not stable due to the recent stabilisation of the f and d target features (tracking issue: #150257) so this probably needs a beta backport unless the stabilisation is reverted.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2026
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

@beetrees beetrees added A-inline-assembly Area: Inline assembly (`asm!(…)`) beta-nominated Nominated for backporting to the compiler in the beta channel. O-riscv Target: RISC-V architecture labels Oct 5, 2026
@beetrees beetrees closed this Oct 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@beetrees beetrees reopened this Oct 5, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-aarch64-gnu-llvm-22-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_expand_queries test:false 0.430
   Compiling rustc_public_bridge v0.0.0 (/checkout/compiler/rustc_public_bridge)
[RUSTC-TIMING] rustc_resolve test:false 29.568

##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Session terminated, killing shell...::group::Clock drift check
  local time: Mon Oct  5 20:17:11 UTC 2026
  network time: Mon, 05 Oct 2026 20:17:11 GMT
##[endgroup]
 ...killed.
##[error]The operation was canceled.

@beetrees beetrees closed this Oct 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@beetrees beetrees reopened this Oct 5, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@tgross35

tgross35 commented Oct 5, 2026

Copy link
Copy Markdown
Member

Relevant stabilization PR: #161385

@petrochenkov

Copy link
Copy Markdown
Contributor

r? @Amanieu

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-inline-assembly Area: Inline assembly (`asm!(…)`) beta-nominated Nominated for backporting to the compiler in the beta channel. O-riscv Target: RISC-V architecture S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants