Skip to content

add regression test for reborrow-invariant-type - #163847

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zanville:add-test-reborrow-type
Oct 26, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zanville:add-test-reborrow-type

Conversation

@zanville

@zanville zanville commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #157313

hey, hope this regression test covers the issue! happy to strengthen the test as well :)

I used cargo bisect-rustc to find what fixed it, and it pointed me to #159103 as more context if that helps

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2026
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @tiif (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

@zanville zanville changed the title add regression test add regression test for reborrow-invariant-type Oct 5, 2026
@tiif

tiif commented Oct 25, 2026

Copy link
Copy Markdown
Member

Thanks! @bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5726406 has been approved by tiif

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 25, 2026
…=tiif

add regression test for reborrow-invariant-type

Fixes rust-lang#157313

hey, hope this regression test covers the issue! happy to strengthen the test as well :)

I used cargo bisect-rustc to find what fixed it, and it pointed me to rust-lang#159103 as more context if that helps
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 25, 2026
…=tiif

add regression test for reborrow-invariant-type

Fixes rust-lang#157313

hey, hope this regression test covers the issue! happy to strengthen the test as well :)

I used cargo bisect-rustc to find what fixed it, and it pointed me to rust-lang#159103 as more context if that helps
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - #163730 (add tests over re-entrancy guarantees for 160776)
 - #164834 (miri subtree update)
 - #164849 (Use the span of the doctest code block fence for figuring out the line number)
 - #164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - #164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - #163458 (stabilize {Rc, Arc}::is_unique)
 - #163499 (vec: stabilise allocators for into_iter)
 - #163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - #163816 (stabilize String::into_chars)
 - #163819 (Correct documentation of what `core::ops::Code` is.)
 - #163847 (add regression test for reborrow-invariant-type)
 - #164006 (Arduously fix typo)
 - #164009 (Update `Ready` future expect messages)
 - #164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - #164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - #164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - #164794 (Expose FloatErrorKind)
 - #164802 (Migrate stable-specific run-make tests to UI tests)
 - #164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - #164903 (rustc-dev-guide subtree update)

Failed merges:

 - #164856 (Switch from `insta` to `expect-test` in bootstrap)
@rust-bors
rust-bors Bot merged commit 8b55dde into rust-lang:main Oct 26, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
Rollup merge of #163847 - zanville:add-test-reborrow-type, r=tiif

add regression test for reborrow-invariant-type

Fixes #157313

hey, hope this regression test covers the issue! happy to strengthen the test as well :)

I used cargo bisect-rustc to find what fixed it, and it pointed me to #159103 as more context if that helps
moabo3li pushed a commit to moabo3li/miri that referenced this pull request Oct 26, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#163730 (add tests over re-entrancy guarantees for 160776)
 - rust-lang/rust#164834 (miri subtree update)
 - rust-lang/rust#164849 (Use the span of the doctest code block fence for figuring out the line number)
 - rust-lang/rust#164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - rust-lang/rust#164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - rust-lang/rust#163458 (stabilize {Rc, Arc}::is_unique)
 - rust-lang/rust#163499 (vec: stabilise allocators for into_iter)
 - rust-lang/rust#163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - rust-lang/rust#163816 (stabilize String::into_chars)
 - rust-lang/rust#163819 (Correct documentation of what `core::ops::Code` is.)
 - rust-lang/rust#163847 (add regression test for reborrow-invariant-type)
 - rust-lang/rust#164006 (Arduously fix typo)
 - rust-lang/rust#164009 (Update `Ready` future expect messages)
 - rust-lang/rust#164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - rust-lang/rust#164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - rust-lang/rust#164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - rust-lang/rust#164794 (Expose FloatErrorKind)
 - rust-lang/rust#164802 (Migrate stable-specific run-make tests to UI tests)
 - rust-lang/rust#164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - rust-lang/rust#164903 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#164856 (Switch from `insta` to `expect-test` in bootstrap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing Reborrow on invariant type has strange behavior.

3 participants