Repository navigation
Rollup of 3 pull requests - #164125
Closed
JonathanBrouwer wants to merge 6 commits into
Closed
Rollup of 3 pull requests#164125JonathanBrouwer wants to merge 6 commits into
JonathanBrouwer wants to merge 6 commits into
Conversation
…match fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check. fixed duplicate emission of error 277 by de-duplicateing the suggestion `suggest_missing_break_or_return_expr`, where a failed normalization leads to E277
```
help: there is a method `bag` with a similar name, but with different arguments
--> $DIR/suggest-methods.rs:9:5
|
LL | trait FooT {
LL | fn bag(&self);
| ^^^^^^^^^^^^^^
```
Co-authored-by: adwin <52573298+adwinwhite@users.noreply.github.com>
…ackh726
[tiny] Show trait span for associated item with similar name
```
help: there is a method `bag` with a similar name, but with different arguments
--> $DIR/suggest-methods.rs:9:5
|
LL | trait FooT {
LL | fn bag(&self);
| ^^^^^^^^^^^^^^
```
…iagnostics, r=mejrs fix misleading diagnostics and improve diagnostics of return type mismatch Fix misleading diagnostics and improve diagnostics of return type mismatch - Fixed misleading suggestions of adding a return and semicolon expression to an expression already in return position by adding a return position check. - Fixed duplicate emission of error 277 by de-duplicateing the suggestion `suggest_missing_break_or_return_expr`, where a failed normalization leads to E277 fixes: rust-lang#162271
…hite set aliases in closure error bodies to rigid with next-solver We already do this in the `DefKind::Closure` arm of `construct_fn`, and not doing so would cause us to ICE, such as in the test. r? project-trait-system-refactor
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit b6a4a13 with merge 7eea2cf... Workflow: https://github.com/rust-lang/rust/actions/runs/38090280784 |
Member
|
Stalled. Closing for an encompassing rollup. |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup