[Kobzol]

View all comments

This is a revival of #142106.

r? @tgross35

[rustbot]

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

[rustbot]

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

[Kobzol]

This list is only needed because we use Mode::ToolStd. This mode checks that the tool isn't using unstable features by default, which is a bit strange, because tools using the local standard library are usually quite special. That being said, we do have things like build-manifest, which should actually be stable.

So I didn't change this step to use another mode, but rather opted into just enumerating all the used unstable features here, same as we do e.g. for test-float-parse.

View changes since the review

[tgross35]

Thank you for finishing this up! I don't know what I got stuck on at #142106, this seems pretty close.

The feature gate changes were done in the subtree already, so I started a sync at #164333. r=me once rebased after that merges.

@SnoozeThis #164333

View changes since this review

[Kobzol]

@bors r=tgross35 rollup=never note="Hard to tell if the tests work everywhere"

Thanks, let's try!

[rust-bors]

📌 Commit 15cecde has been approved by tgross35

It is now in the queue for this repository.

[rust-bors]

💔 Test for b3fa158 failed: CI. Failed job:

• auto - test-x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[tgross35]

I'm not sure where that's coming from, why isn't it just using the version in

rust/library/Cargo.lock

Line 43 in 5d8fec0

version = "1.4.3"

? I guess

rust/library/compiler-builtins/Cargo.toml

Line 42 in 5d8fec0

cc = "1.2.56"

and

rust/library/compiler-builtins/builtins-shim/Cargo.toml

Line 39 in 5d8fec0

cc = { version = "1.2", optional = true }

could be bumped if it helps.

[tgross35]

I suppose,
@rustbot author

[Kobzol]

@bors try jobs=test-x86_64-gnu-distcheck

[Kobzol]

Huh, turns out that I should have rebased this PR before picking it up 😆 I was using a quite old stdlib lockfile.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Kobzol]

@bors try jobs=test-x86_64-gnu-distcheck

[rust-bors]

💔 Test for 61cadb7 failed: CI. Failed job:

• try - test-x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[Kobzol]

I was on the wrong track. The problem is this.

@bors try jobs=test-x86_64-gnu-distcheck

[rust-bors]

☀️ Try build successful (CI)
Build commit: d357e84 (d357e844d819c9f9ffce588d6662d3c84e36bd58)
Base parent: aaf324d (aaf324d50a7dcb17aae7f2a37e15ff143d980c6e)

[Kobzol]

Yay, finally! Let's try again.

@bors r=tgross35

[rust-bors]

📌 Commit 8f496d4 has been approved by tgross35

It is now in the queue for this repository.

[rust-log-analyzer]

The job test-x86_64-gnu-distcheck failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- tempfile::tests::named_temp_file_new_creates_file stdout ----

thread 'tempfile::tests::named_temp_file_new_creates_file' (395576) panicked at src/tools/rust-analyzer/crates/stdx/src/tempfile.rs:238:9:
assertion failed: !fs::exists(path).unwrap()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- tempfile::tests::named_temp_file_new_creates_file stdout end ----

failures:
    tempfile::tests::named_temp_file_new_creates_file

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.29ms

error: test failed, to rerun pass `-p stdx --lib`
Build completed unsuccessfully in 1:18:50
make: *** [Makefile:49: check] Error 1
Bootstrap failed while executing `test distcheck`
Currently active steps:
test::Distcheck {  } at src/bootstrap/src/core/build_steps/test.rs:4084
Command `make check [workdir=/tmp/distcheck/distcheck-rustc-src]` failed with exit code 2
Created at: src/bootstrap/src/core/build_steps/test.rs:4132:5
Executed at: src/bootstrap/src/core/build_steps/test.rs:4138:10

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 1:27:11
  local time: Mon Oct 26 16:59:35 UTC 2026
  network time: Mon, 26 Oct 2026 16:59:35 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

[rust-bors]

💔 Test for 5e245fa failed: CI. Failed job:

• auto - test-x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[tgross35]

I think that's been a spurious failure

@bors retry

[Kobzol]

It looks like so, yeah. Funny that it happened in distcheck again..