Complete the various renamings of terms belonging to feature `checked_type_aliases` by fmease · Pull Request #164528 · rust-lang/rust

fmease · 2026-10-18T17:17:44Z

Various terms used in the context of feature checked_type_aliases have undergone renamings. See PRs #140249 and #158758. However, these PRs didn't update every single occurrence. This PR rectifies that.

For context, the renamings are

weak (alias (type)) → free (alias (type))
lazy (type alias) → checked (type alias), LTA → CTA
eager (type alias) → unchecked (type alias)

Moreover, I've renamed tests/ui/checked-type-alias/ to tests/ui/checked-type-aliases/ in accordance with the name of the feature, checked_type_aliases.

_{(No LLM was or will be used by me during the entire creation process of this PR)}

rustbot · 2026-10-18T17:17:49Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 20 candidates

fmease · 2026-10-18T17:20:22Z


    if !usage_spans.is_empty() {
-        // First, check if the ADT/LTA is (probably) cyclical. We say probably here, since we're
+        // First, check if the ADT is (probably) cyclical. We say probably here, since we're


Since #141030 we no longer consider CTAs here.

View changes since the review

chenyukang · 2026-10-23T04:30:20Z

with file name changed, the comment also need to updated?

 tests/ui/checked-type-aliases/constrained-late-bound-regions.rs:2   // Weak alias types constrain late-bound regions ...
 tests/ui/checked-type-aliases/unconstrained-late-bound-regions.rs:1 // Weak alias types only constrain ...
 tests/ui/coherence/orphan-check-free-aliases-covering.rs:1          // Weak aliases cover type parameters ...
 tests/ui/coherence/orphan-check-free-aliases-not-covering.rs:1      // Weak aliases might not cover ...

chenyukang · 2026-10-23T04:31:53Z

 //
 // Listed below are ill-formed type system entities which we don't reject since they appear inside
-// the definition of (eager) type aliases. These type aliases are intentionally not referenced from
-// anywhere to prevent the eagerly expanded / instantiated aliased types from getting wfchecked
+// the definition of (unchcked) type aliases. These type aliases are intentionally not referenced


Suggested change

// the definition of (unchcked) type aliases. These type aliases are intentionally not referenced

// the definition of (unchecked) type aliases. These type aliases are intentionally not referenced

View changes since the review

chenyukang · 2026-10-23T04:34:36Z

r=me after fixed issues in comment.

fmease · 2026-10-23T09:34:49Z

with file name changed, the comment also need to updated?

Oops, I only did a case sensitive ripgrep for weak, eager & lazy ^^'. Gonna use rg -i now.

And "eager (type alias)" with "unchecked (type alias)".

fmease · 2026-10-23T12:39:09Z

@bors r=chenyukang rollup

rust-bors · 2026-10-23T12:39:13Z

📌 Commit fe64545 has been tentatively approved by chenyukang

It will be put into the queue for this repository once PR CI succeeds.

in accordance with the corresponding feature name, `checked_type_aliases`.

Complete the various renamings of terms belonging to feature `checked_type_aliases` Various terms used in the context of feature `checked_type_aliases` have undergone renamings. See PRs rust-lang#140249 and rust-lang#158758. However, these PRs didn't update every single occurrence. This PR rectifies that. For context, the renamings are 1. weak (alias (type)) → free (alias (type)) 2. lazy (type alias) → checked (type alias), LTA → CTA 3. eager (type alias) → unchecked (type alias) Moreover, I've renamed `tests/ui/checked-type-alias/` to `tests/ui/checked-type-aliases/` in accordance with the name of the feature, `checked_type_aliases`. <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>

Rollup of 9 pull requests Successful merges: - #164792 (rustc_codegen_cranelift subtree update) - #163799 (std: keep value of `local_pointer!` until `thread_cleanup` is run) - #164781 (Bump dist-x86_64-illumos to Ubuntu 22.04) - #160902 (borrowck dataflow: respect borrow shallowness when killing borrows that conflict with assignments) - #163684 (suggest named lifetimes instead of `'_` in `use<...>` for E0700) - #164167 (Account for `use foo as bar;` on resolution error suggestions) - #164438 (Make async drop shim proxy pinned) - #164528 (Complete the various renamings of terms belonging to feature `checked_type_aliases`) - #164796 (miri: fix ICE when caller signature is c-variadic but callee is not)

Rollup merge of #164528 - fmease:cta-renamings, r=chenyukang Complete the various renamings of terms belonging to feature `checked_type_aliases` Various terms used in the context of feature `checked_type_aliases` have undergone renamings. See PRs #140249 and #158758. However, these PRs didn't update every single occurrence. This PR rectifies that. For context, the renamings are 1. weak (alias (type)) → free (alias (type)) 2. lazy (type alias) → checked (type alias), LTA → CTA 3. eager (type alias) → unchecked (type alias) Moreover, I've renamed `tests/ui/checked-type-alias/` to `tests/ui/checked-type-aliases/` in accordance with the name of the feature, `checked_type_aliases`. <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>

Rollup of 9 pull requests Successful merges: - rust-lang/rust#164792 (rustc_codegen_cranelift subtree update) - rust-lang/rust#163799 (std: keep value of `local_pointer!` until `thread_cleanup` is run) - rust-lang/rust#164781 (Bump dist-x86_64-illumos to Ubuntu 22.04) - rust-lang/rust#160902 (borrowck dataflow: respect borrow shallowness when killing borrows that conflict with assignments) - rust-lang/rust#163684 (suggest named lifetimes instead of `'_` in `use<...>` for E0700) - rust-lang/rust#164167 (Account for `use foo as bar;` on resolution error suggestions) - rust-lang/rust#164438 (Make async drop shim proxy pinned) - rust-lang/rust#164528 (Complete the various renamings of terms belonging to feature `checked_type_aliases`) - rust-lang/rust#164796 (miri: fix ICE when caller signature is c-variadic but callee is not)

rust-timer · 2026-10-27T08:58:15Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (575f569): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.4%, -0.0%]	12
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Artifact size: 406.24 MiB -> 406.29 MiB (0.01%)

fmease added C-cleanup Category: PRs that clean code up or issues documenting cleanup. F-checked_type_aliases `#![feature(checked_type_aliases)]` (formerly: `lazy_type_alias`) labels Oct 18, 2026

rustbot assigned chenyukang Oct 18, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2026

fmease commented Oct 18, 2026

View reviewed changes

chenyukang reviewed Oct 23, 2026

View reviewed changes

fmease added this to Checked Type Aliases (CTA) Oct 23, 2026

fmease moved this to In Progress in Checked Type Aliases (CTA) Oct 23, 2026

fmease added 2 commits October 23, 2026 14:33

Replace "weak (alias)" with "free (alias (type))"

bb99fe6

Replace "lazy (type alias)" with "checked (type alias)"

9291760

And "eager (type alias)" with "unchecked (type alias)".

fmease force-pushed the cta-renamings branch from 8fe68e3 to fe64545 Compare October 23, 2026 12:38

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2026

fmease added 2 commits October 23, 2026 14:40

Replace "LTA" with "CTA"

403a476

Rename tests/ui/checked-type-alias to tests/ui/checked-type-aliases

fe64545

in accordance with the corresponding feature name, `checked_type_aliases`.

fmease mentioned this pull request Oct 23, 2026

Rollup of 9 pull requests #164804

Merged

JonathanBrouwer mentioned this pull request Oct 23, 2026

Rollup of 9 pull requests #164805

Closed

rust-bors Bot merged commit 3be2d85 into rust-lang:main Oct 23, 2026
14 checks passed

github-project-automation Bot moved this from In Progress to Done in Checked Type Aliases (CTA) Oct 23, 2026

rustbot added this to the 1.101.0 milestone Oct 23, 2026

fmease deleted the cta-renamings branch October 23, 2026 18:55

github-actions Bot mentioned this pull request Oct 26, 2026

Toolchain upgrade to nightly-2026-10-28 flux-rs/flux#1884

Draft

fmease mentioned this pull request Oct 29, 2026

Tracking issue for checked type aliases #112792

Open

2 of 6 tasks

Navigation Menu

Repository navigation

Complete the various renamings of terms belonging to feature `checked_type_aliases` - #164528

Complete the various renamings of terms belonging to feature `checked_type_aliases`#164528
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
fmease:cta-renamings

fmease commented Oct 18, 2026 •

edited

Loading

Uh oh!

rustbot commented Oct 18, 2026

Uh oh!

fmease Oct 18, 2026 •

edited by rustbot

Loading

Uh oh!

chenyukang commented Oct 23, 2026

Uh oh!

chenyukang Oct 23, 2026 •

edited by rustbot

Loading

Uh oh!

chenyukang commented Oct 23, 2026

Uh oh!

fmease commented Oct 23, 2026 •

edited

Loading

Uh oh!

fmease commented Oct 23, 2026

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 27, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// the definition of (unchcked) type aliases. These type aliases are intentionally not referenced
	// the definition of (unchecked) type aliases. These type aliases are intentionally not referenced

Conversation

fmease commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 18, 2026

Uh oh!

fmease Oct 18, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenyukang commented Oct 23, 2026

Uh oh!

chenyukang Oct 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenyukang commented Oct 23, 2026

Uh oh!

fmease commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Oct 23, 2026

Uh oh!

rust-bors Bot commented Oct 23, 2026

Uh oh!

Uh oh!

rust-timer commented Oct 27, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fmease commented Oct 18, 2026 •

edited

Loading

fmease Oct 18, 2026 •

edited by rustbot

Loading

chenyukang Oct 23, 2026 •

edited by rustbot

Loading

fmease commented Oct 23, 2026 •

edited

Loading