Skip to content

Rollup of 4 pull requests - #164554

Closed
tgross35 wants to merge 12 commits into
rust-lang:mainfrom
tgross35:rollup-3kz7Ap2
Closed

Rollup of 4 pull requests#164554
tgross35 wants to merge 12 commits into
rust-lang:mainfrom
tgross35:rollup-3kz7Ap2

Conversation

@tgross35

@tgross35 tgross35 commented Oct 19, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

brad0 and others added 12 commits October 16, 2026 19:15
@brad0
Bump libc to v0.2.191
b728431
@GuillaumeGomez
Clean up tests/rustdoc-html
f994970
@estebank
[tiny] Remove some useless .into() calls
cb8b18d
@pascaldekloe @tgross35
flt2dec front with format_short and format_fixed
9ccee51 
* Fallback from Grisu to Dragon in flt2dec front
* Together with name change to ensure all use checked
* Drop of Grisu benchmarks which tested Dragon fallback
* Documentation at functions instead of module level

The values dropped in the benchmarks of Grisu are still covered in the Dragon
benchmarks. All use of the format functions shows in this patch due to the name
change. This ensures we don't leave any code behind which still uses strategy
directly by accident.
@pascaldekloe @tgross35
less abstraction in equivelance of flt2dec/random.rs
8fb0702 
"A little copying is better than a little dependency."
— Rob Pike

* Equivalence comparison explicit instead of generic
* Bit patterns specified as ops::Range constants
* No panic on invalid UTF-8 in equivalence test
@pascaldekloe @tgross35
test of flt2dec::format_short & flt2dec::format_fixed normalized
baa2a5b 
* No generics abstraction of Grisu and Dragon
* The stringify! of input in assertion message
* TestableFloat abstraction omitted with macro
* MSVC omission direct on respective test
* FIX test missed verification of the last digit
* FIX test assertion value miss due the previous

Unified signature plus description on assertion tools:
* check_shortest! -> check_short!
* try_exact! -> check_fixed_buf_match!
* try_fixed! -> check_fixed_resolution!
* check_exact & check_exact! -> check_fixed_mix!
* check_exact_one -> check_coef_pow2!
@pascaldekloe @tgross35
typo in test value from round-to-even in fmt
49d1c1c 
Inverted assertion order. It's not the value of exp which steers the branche.
The concern at hand is not having any digits (i.e, an empty buffer). The reason
for not having digits can be asserted, as an optional double check, just to be
more sure we ended up without digits for the correct reason.

Both the current and the correct value are equivalent when rounded to three decimals.
@pascaldekloe @tgross35
flt2dec/random.rs renamed to flt2dec/equiv.rs
99c4dff
@tgross35
Rollup merge of rust-lang#154505 - pascaldekloe:flt2dec-uni, r=tgross35
9cea069 
flt2dec front of format_short & format_fixed

The fallback to Dragon was placed in the Grisu module. As a result tests don't test what they appear to test, and some benchmarks from Grisu measured Dragon instead.

The corrected values in the tests haven been verified against the Go implementation.
@tgross35
Rollup merge of rust-lang#163732 - brad0:libc_crate, r=tgross35
53b9a54 
Bump libc to v0.2.191

Various bug fixes and additions including getexecpath() support.
@tgross35
Rollup merge of rust-lang#164532 - estebank:usesless-into-calls, r=ko…
d2f6249 
…bzol

[tiny] Remove some useless `.into()` calls

Detected while working on rust-lang#129249.
@tgross35
Rollup merge of rust-lang#164523 - GuillaumeGomez:more-html-cleanups,…
88cad6f 
… r=Urgau

Clean up `tests/rustdoc-html`

Yet another one. This one is a bit different though because it made me realize that a `!has` was not checking anything so I fixed it. I'm considering more and more to remove the use of `!` or at least strongly restrict it.

r? @Urgau
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 19, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 19, 2026
@tgross35

tgross35 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@bors r+ force rollup=never p=5

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 88cad6f has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@rust-bors rust-bors Bot mentioned this pull request Oct 19, 2026
Open
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 19, 2026
@bors
Auto merge of #164554 - tgross35:rollup-3kz7Ap2, r=tgross35
c86ad03 
Rollup of 4 pull requests

Successful merges:

 - #154505 (flt2dec front of format_short & format_fixed)
 - #163732 (Bump libc to v0.2.191)
 - #164532 ([tiny] Remove some useless `.into()` calls)
 - #164523 (Clean up `tests/rustdoc-html`)
@rust-log-analyzer

rust-log-analyzer commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

The job test-x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] memchr test:false 1.861
warning: constant `F16_POS_FIN_RANGE` is never used
  --> library\coretests\tests\num\flt2dec\equiv.rs:13:7
   |
13 | const F16_POS_FIN_RANGE: std::ops::Range<u16> = 1..f16::INFINITY.to_bits();
   |       ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default

[RUSTC-TIMING] object test:false 8.621
---
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Currently active steps:
test::Crate { build_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu, mode: Std, crates: ["alloc", "alloctests", "compiler_builtins", "core", "coretests", "panic_abort", "panic_unwind", "proc_macro", "rustc-std-workspace-core", "std", "std_detect", "sysroot", "test", "unwind"] } at src\bootstrap\src\core\build_steps\test.rs:3622
Build completed unsuccessfully in 1:16:03
make: *** [Makefile:126: ci-mingw-x] Error 1
  local time: Mon Oct 19 03:47:46 CUT 2026
  network time: Mon, 19 Oct 2026 03:47:47 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2026
@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c86ad03 failed: CI. Failed job:

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

PR #154505, which is a member of this rollup, was unapproved.

@tgross35

tgross35 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

#154505

@tgross35 tgross35 closed this Oct 19, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 19, 2026
@tgross35
tgross35 deleted the rollup-3kz7Ap2 branch October 19, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tgross35 @rust-log-analyzer @rustbot @brad0 @GuillaumeGomez @estebank @pascaldekloe