Skip to content

Implement PartialOrd between mixed-mutability references - #164637

Draft
Jules-Bertholet wants to merge 1 commit into
rust-lang:mainfrom
Jules-Bertholet:mixed-cmp
Draft

Jules-Bertholet wants to merge 1 commit into
rust-lang:mainfrom
Jules-Bertholet:mixed-cmp

Conversation

@Jules-Bertholet

@Jules-Bertholet Jules-Bertholet commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

For consistency with PartialEq.

Needs a crater run (#164610)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 20, 2026
@rustbot

rustbot commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 37 candidates
  • Random selection from 6 candidates

@Jules-Bertholet
Jules-Bertholet marked this pull request as draft October 20, 2026 14:09
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2026
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Oct 20, 2026
@theemathas theemathas added the needs-crater This change needs a crater run to check for possible breakage in the ecosystem. label Oct 20, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-miri failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_attr_ir test:false 6.269
error[E0277]: can't compare `Val` with `&Val`
   --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/datafrog-2.0.1/src/treefrog.rs:379:50
    |
379 |                 slice = gallop(slice, |kv| &kv.1 < v);
    |                                                  ^ no implementation for `Val < &Val` and `Val > &Val`
    |
    = note: required for `&Val` to implement `PartialOrd<&&Val>`
help: consider dereferencing here
    |
379 |                 slice = gallop(slice, |kv| &kv.1 < *v);
    |                                                    +
help: consider further restricting type parameter `Val` with trait `PartialOrd`
    |
360 |         Val: Ord + 'leap + std::cmp::PartialOrd<&Val>,
    |                          ++++++++++++++++++++++++++++

error[E0277]: can't compare `Val` with `&Val`
   --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/datafrog-2.0.1/src/treefrog.rs:464:54
    |
464 |                     slice = gallop(slice, |kv| &kv.1 < v);
    |                                                      ^ no implementation for `Val < &Val` and `Val > &Val`
    |
    = note: required for `&Val` to implement `PartialOrd<&&Val>`
help: consider dereferencing here
    |
464 |                     slice = gallop(slice, |kv| &kv.1 < *v);
    |                                                        +
help: consider further restricting type parameter `Val` with trait `PartialOrd`
    |
442 |     impl<'leap, Key: Ord, Val: Ord + 'leap + std::cmp::PartialOrd<&Val>, Tuple: Ord, Func> Leaper<'leap, Tuple, Val>
    |                                            ++++++++++++++++++++++++++++

For more information about this error, try `rustc --explain E0277`.
[RUSTC-TIMING] datafrog test:false 0.415
error: could not compile `datafrog` (lib) due to 2 previous errors

@rust-bors

rust-bors Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #165918) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-crater This change needs a crater run to check for possible breakage in the ecosystem. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants