Repository navigation
Check supported features per CodegenBackend - #164714
Draft
TechnoPorg wants to merge 1 commit into
Draft
TechnoPorg wants to merge 1 commit into
TechnoPorg wants to merge 1 commit into
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TechnoPorg
force-pushed
the
codegen-backend-supported-features
branch
from
October 27, 2026 12:55
6b41a28 to
d911333
Compare
This comment has been minimized.
This comment has been minimized.
antoyo
reviewed
Oct 28, 2026
TechnoPorg
force-pushed
the
codegen-backend-supported-features
branch
from
October 28, 2026 23:42
d911333 to
5a76d73
Compare
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
TechnoPorg
force-pushed
the
codegen-backend-supported-features
branch
2 times, most recently
from
October 29, 2026 12:40
7d42993 to
303edbe
Compare
TechnoPorg
force-pushed
the
codegen-backend-supported-features
branch
from
October 30, 2026 12:46
303edbe to
d009976
Compare
Contributor
|
☔ The latest upstream changes (presumably #165918) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164533
Of the possible designs discussed in that issue, this goes with the struct option rather than the
CodegenBackendmethod option, as the former is easier to attach toSession, whereas the latter would require passing around theCodegenBackend.There is a remarkable number of LLVM-specific compiler options that get ignored by other backends, and I'm not sure which of these, if any, we should attempt to validate with other backends.
This PR is a draft because I'm not familiar enough with the compiler yet to say what the best design is, and I think it's easier to iterate on it with actual code in front of us:
Session, rather than in its methods?r? @ZuseZ4
cc @RalfJung, @antoyo, @GuillaumeGomez, @bjorn3 as participants on the issue thread.
@rustbot label C-cleanup T-compiler A-codegen