Skip to content

Update LLVM PassBuilder constructor calls to pass a context - #164737

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
zmodem:passbuilder
Oct 23, 2026
Merged

Update LLVM PassBuilder constructor calls to pass a context#164737
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
zmodem:passbuilder

Conversation

@zmodem

@zmodem zmodem commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

LLVM's llvm/llvm-project#233150 made the PassBuilder constructor take a LLVMContext argument.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 22, 2026
@rustbot

rustbot commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@zmodem

zmodem commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Oct 22, 2026
@zmodem

zmodem commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

r? @nikic

@rustbot rustbot assigned nikic and unassigned cuviper Oct 22, 2026
nikic
nikic reviewed Oct 22, 2026
View reviewed changes
Comment thread compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp Resolved
@zmodem
zmodem requested a review from nikic October 22, 2026 11:08
@nikic

nikic commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 31d8b41 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 22, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 22, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
b8fa1fb 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
eb022b1 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Auto merge of #164757 - JonathanBrouwer:rollup-QMS3ewH, r=JonathanBro…
0cefa27 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #164458 (Avoid stdlib's `impl Hash for Path` for stable hashing)
 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163586 (refactor Windows remove_dir_all)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164307 (Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck`)
 - #164425 (Declare `SyntaxContext` through `rustc_index::newtype_index!`)
 - #156841 (Avoid cloning CFG-related analysis data.)
 - #164654 (Add reference annotations for unions)
 - #164717 (Allow `llm-assisted` label to be set without write access)
 - #164735 (Remove docs mentioning instability of wasm64)
 - #164737 (Update LLVM PassBuilder constructor calls to pass a context)

Failed merges:

 - #164636 (Remove `record_*` macros from the metadata encoder)
@rust-bors
rust-bors Bot merged commit dce705a into rust-lang:main Oct 23, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 23, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 23, 2026
@bors
Unrolled build for #164737 in rollup 164757
e8146b0 
Rollup merge of #164737 - zmodem:passbuilder, r=nikic

Update LLVM PassBuilder constructor calls to pass a context

LLVM's llvm/llvm-project#233150 made the PassBuilder constructor take a LLVMContext argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic Awaiting requested review from nikic

Assignees

@nikic nikic

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zmodem @rustbot @nikic @cuviper