Repository navigation
Add regression tests for #156380 - #164888
Merged
rust-bors[bot] merged 1 commit intoOct 26, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @nnethercote (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
yashaggarwal85d
force-pushed
the
fix-156380-reborrow-test
branch
from
October 25, 2026 07:26
8090098 to
178c4e1
Compare
nnethercote
approved these changes
Oct 26, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…w-test, r=nnethercote Add regression tests for rust-lang#156380 Adds two ui tests in `tests/ui/reborrow` for the two snippets in rust-lang#156380. The first one (moving a `String` out of a `Reborrow` type twice) was fixed by rust-lang#156784. That PR has its own test but with a different struct, so this adds the exact repro from the issue. The second one (getting two aliasing `&mut i32` through a generic field) had no test. It compiles on nightly-2026-08-28 and errors on nightly-2026-08-29, which points at rust-lang#159103. I checked both by hand: they compile on nightly-2026-05-20 and error on the current nightly, with and without `-Znext-solver`. Fixes rust-lang#156380 Disclaimer - AI was used to explore and get the understanding of the codebase. All the changes and tests are executed and reviewed by me personally. Thansk
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…w-test, r=nnethercote Add regression tests for rust-lang#156380 Adds two ui tests in `tests/ui/reborrow` for the two snippets in rust-lang#156380. The first one (moving a `String` out of a `Reborrow` type twice) was fixed by rust-lang#156784. That PR has its own test but with a different struct, so this adds the exact repro from the issue. The second one (getting two aliasing `&mut i32` through a generic field) had no test. It compiles on nightly-2026-08-28 and errors on nightly-2026-08-29, which points at rust-lang#159103. I checked both by hand: they compile on nightly-2026-05-20 and error on the current nightly, with and without `-Znext-solver`. Fixes rust-lang#156380 Disclaimer - AI was used to explore and get the understanding of the codebase. All the changes and tests are executed and reviewed by me personally. Thansk
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 12 pull requests Successful merges: - #162808 (Enable `--generate-link-to-definition` rustdoc option on std docs) - #163219 (assumptions_on_binders: Test mixed ambiguous ORs) - #164985 (Only recover if we may for `recover_missing_dot`) - #161521 (Replace check_attr_crate_level with check_target for #[doc]) - #162530 (Move #[naked] attribute check to attribute parsing stage) - #164103 (trait solver: Resolve region vars before eager placeholder handling) - #164692 (move `ppcf128` lang item to `core::num::imp`) - #164702 (Point at `impl` through which associated function is provided) - #164776 (Account for trait object with implicit `'static` lifetime in field type being returned) - #164791 (Self param after const param) - #164856 (Switch from `insta` to `expect-test` in bootstrap) - #164888 (Add regression tests for #156380)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 14 pull requests Successful merges: - #163219 (assumptions_on_binders: Test mixed ambiguous ORs) - #164985 (Only recover if we may for `recover_missing_dot`) - #161521 (Replace check_attr_crate_level with check_target for #[doc]) - #162530 (Move #[naked] attribute check to attribute parsing stage) - #164103 (trait solver: Resolve region vars before eager placeholder handling) - #164692 (move `ppcf128` lang item to `core::num::imp`) - #164702 (Point at `impl` through which associated function is provided) - #164741 (Use explicit target cpu in tests parsing generated asm) - #164767 (Add regression tests for transmutability issues) - #164776 (Account for trait object with implicit `'static` lifetime in field type being returned) - #164791 (Self param after const param) - #164856 (Switch from `insta` to `expect-test` in bootstrap) - #164888 (Add regression tests for #156380) - #164967 (Add codegen test for power of two implying nonzero with debuginfo)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup merge of #164888 - yashaggarwal85d:fix-156380-reborrow-test, r=nnethercote Add regression tests for #156380 Adds two ui tests in `tests/ui/reborrow` for the two snippets in #156380. The first one (moving a `String` out of a `Reborrow` type twice) was fixed by #156784. That PR has its own test but with a different struct, so this adds the exact repro from the issue. The second one (getting two aliasing `&mut i32` through a generic field) had no test. It compiles on nightly-2026-08-28 and errors on nightly-2026-08-29, which points at #159103. I checked both by hand: they compile on nightly-2026-05-20 and error on the current nightly, with and without `-Znext-solver`. Fixes #156380 Disclaimer - AI was used to explore and get the understanding of the codebase. All the changes and tests are executed and reviewed by me personally. Thansk
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#163219 (assumptions_on_binders: Test mixed ambiguous ORs) - rust-lang/rust#164985 (Only recover if we may for `recover_missing_dot`) - rust-lang/rust#161521 (Replace check_attr_crate_level with check_target for #[doc]) - rust-lang/rust#162530 (Move #[naked] attribute check to attribute parsing stage) - rust-lang/rust#164103 (trait solver: Resolve region vars before eager placeholder handling) - rust-lang/rust#164692 (move `ppcf128` lang item to `core::num::imp`) - rust-lang/rust#164702 (Point at `impl` through which associated function is provided) - rust-lang/rust#164741 (Use explicit target cpu in tests parsing generated asm) - rust-lang/rust#164767 (Add regression tests for transmutability issues) - rust-lang/rust#164776 (Account for trait object with implicit `'static` lifetime in field type being returned) - rust-lang/rust#164791 (Self param after const param) - rust-lang/rust#164856 (Switch from `insta` to `expect-test` in bootstrap) - rust-lang/rust#164888 (Add regression tests for #156380) - rust-lang/rust#164967 (Add codegen test for power of two implying nonzero with debuginfo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two ui tests in
tests/ui/reborrowfor the two snippets in #156380.The first one (moving a
Stringout of aReborrowtype twice) was fixed by #156784. That PR has its own test but with a different struct, so this adds the exact repro from the issue.The second one (getting two aliasing
&mut i32through a generic field) had no test. It compiles on nightly-2026-08-28 and errors on nightly-2026-08-29, which points at #159103.I checked both by hand: they compile on nightly-2026-05-20 and error on the current nightly, with and without
-Znext-solver.Fixes #156380
Disclaimer - AI was used to explore and get the understanding of the codebase. All the changes and tests are executed and reviewed by me personally. Thansk