Remove `TypeKind` from `rustc_codegen_ssa` by beetrees · Pull Request #164924 · rust-lang/rust

beetrees · 2026-10-25T18:39:53Z

TypeKind is a very LLVM-shaped enum (e.g. there is a single TypeKind::Integer but multiple variants for floats because that's what LLVM does) - other backends (e.g. rustc_codegen_gcc) usually don't have a single call to get the required information and have to check for each variant individually, even though most callers only care if a type is one or at most a few variants. This PR removes TypeKind and cx.type_kind() from rustc_codegen_ssa, replacing them with Option-returning methods int_width, float_type and vector_element_type_and_length.

cc @antoyo for rustc_codegen_gcc

r? @bjorn3

rustbot · 2026-10-25T18:39:56Z

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

GuillaumeGomez

Much easier to read, I like it. 👍

View changes since this review

antoyo · 2026-10-25T21:21:58Z

The failure is a know issue currently being resolved: #164929

bjorn3 · 2026-10-27T13:55:38Z

@bors r+

rust-bors · 2026-10-27T13:55:42Z

📌 Commit 599ce90 has been approved by bjorn3

It is now in the queue for this repository.

rustbot · 2026-10-27T18:48:07Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

beetrees · 2026-10-27T18:48:25Z

@bors r=bjorn3

rust-bors · 2026-10-27T18:48:29Z

📌 Commit 7e1341e has been tentatively approved by bjorn3

It will be put into the queue for this repository once PR CI succeeds.

@antoyo

Remove `TypeKind` from `rustc_codegen_ssa` `TypeKind` is a very LLVM-shaped enum (e.g. there is a single `TypeKind::Integer` but multiple variants for floats because that's what LLVM does) - other backends (e.g. `rustc_codegen_gcc`) usually don't have a single call to get the required information and have to check for each variant individually, even though most callers only care if a type is one or at most a few variants. This PR removes `TypeKind` and `cx.type_kind()` from `rustc_codegen_ssa`, replacing them with `Option`-returning methods `int_width`, `float_type` and `vector_element_type_and_length`. cc @antoyo for `rustc_codegen_gcc` r? @bjorn3

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@antoyo

Remove `TypeKind` from `rustc_codegen_ssa` `TypeKind` is a very LLVM-shaped enum (e.g. there is a single `TypeKind::Integer` but multiple variants for floats because that's what LLVM does) - other backends (e.g. `rustc_codegen_gcc`) usually don't have a single call to get the required information and have to check for each variant individually, even though most callers only care if a type is one or at most a few variants. This PR removes `TypeKind` and `cx.type_kind()` from `rustc_codegen_ssa`, replacing them with `Option`-returning methods `int_width`, `float_type` and `vector_element_type_and_length`. cc @antoyo for `rustc_codegen_gcc` r? @bjorn3

…uwer Rollup of 23 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #165123 (Temporarily drop macos-26 jobs) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165123 (Temporarily drop macos-26 jobs) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@antoyo

Rollup merge of #164924 - beetrees:no-ssa-type-kind, r=bjorn3 Remove `TypeKind` from `rustc_codegen_ssa` `TypeKind` is a very LLVM-shaped enum (e.g. there is a single `TypeKind::Integer` but multiple variants for floats because that's what LLVM does) - other backends (e.g. `rustc_codegen_gcc`) usually don't have a single call to get the required information and have to check for each variant individually, even though most callers only care if a type is one or at most a few variants. This PR removes `TypeKind` and `cx.type_kind()` from `rustc_codegen_ssa`, replacing them with `Option`-returning methods `int_width`, `float_type` and `vector_element_type_and_length`. cc @antoyo for `rustc_codegen_gcc` r? @bjorn3

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#165032 (stdarch subtree update) - rust-lang/rust#165123 (Temporarily drop macos-26 jobs) - rust-lang/rust#165072 (Submodule update of rustc-perf) - rust-lang/rust#144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - rust-lang/rust#162342 (More stdarch regression tests) - rust-lang/rust#163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - rust-lang/rust#164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - rust-lang/rust#164916 (CI: rfl: move job forward to Linux v7.3) - rust-lang/rust#164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - rust-lang/rust#164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - rust-lang/rust#165083 (Gate `z` inline asm template modifier) - rust-lang/rust#165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - rust-lang/rust#161131 (Check associated const binding types) - rust-lang/rust#161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - rust-lang/rust#164315 (make powerpc `Complex` ABI GCC-compatible) - rust-lang/rust#164476 (Avoid ICE on None from prepare_vtable_segments) - rust-lang/rust#165003 (follow up for global-alloc-reentry test) - rust-lang/rust#165020 (Bless mir-opt panic-abort tests) - rust-lang/rust#165066 (skip max_repr_align in Layout::eq_abi) - rust-lang/rust#165080 (Syntactically allow C-variadics in parenthesized argument lists) - rust-lang/rust#165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - rust-lang/rust#165082 (Remove stability note from `rust_splat`)

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Oct 25, 2026

rustbot assigned bjorn3 Oct 25, 2026

rustbot added F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2026

GuillaumeGomez approved these changes Oct 25, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

antoyo reviewed Oct 25, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_gcc/src/type_.rs Resolved

Comment thread compiler/rustc_codegen_ssa/src/traits/type_.rs Resolved

antoyo reviewed Oct 25, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/traits/type_.rs Resolved

beetrees force-pushed the no-ssa-type-kind branch from 7cabd70 to 6278fa6 Compare October 25, 2026 21:06

This comment has been minimized.

Sign in to view

folkertdev reviewed Oct 25, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_gcc/src/builder.rs Resolved

Comment thread compiler/rustc_codegen_gcc/src/int.rs Resolved

Comment thread compiler/rustc_codegen_llvm/src/builder/gpu_offload.rs Resolved

Comment thread compiler/rustc_codegen_llvm/src/type_.rs Resolved

antoyo reviewed Oct 25, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_gcc/src/intrinsic/simd.rs Resolved

beetrees force-pushed the no-ssa-type-kind branch 4 times, most recently from 0b25baf to 4a47ac5 Compare October 25, 2026 23:40

This comment has been minimized.

Sign in to view

bjorn3 reviewed Oct 26, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder.rs Resolved

bjorn3 reviewed Oct 26, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder/gpu_offload.rs Resolved

bjorn3 reviewed Oct 26, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/intrinsic.rs Resolved

beetrees force-pushed the no-ssa-type-kind branch from 4a47ac5 to 02162e4 Compare October 26, 2026 16:39

This comment has been minimized.

Sign in to view

beetrees force-pushed the no-ssa-type-kind branch from 02162e4 to 599ce90 Compare October 26, 2026 19:35

This comment has been minimized.

Sign in to view

Remove TypeKind from rustc_codegen_ssa

7e1341e

beetrees force-pushed the no-ssa-type-kind branch from 599ce90 to 7e1341e Compare October 27, 2026 18:48

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2026

JonathanBrouwer mentioned this pull request Oct 28, 2026

Rollup of 22 pull requests #165095

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 23 pull requests #165130

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 22 pull requests #165151

Merged

rust-bors Bot merged commit fcde28a into rust-lang:main Oct 29, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 29, 2026

beetrees deleted the no-ssa-type-kind branch October 29, 2026 23:13

calebzulawski mentioned this pull request Oct 31, 2026

Add SIMD algebraic intrinsics #164952

Open

Conversation

beetrees commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 25, 2026

Uh oh!

GuillaumeGomez left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

antoyo commented Oct 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bjorn3 commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 27, 2026

Uh oh!

beetrees commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

beetrees commented Oct 25, 2026 •

edited

Loading

GuillaumeGomez left a comment •

edited by rustbot

Loading