Rollup of 6 pull requests by JonathanBrouwer · Pull Request #164940 · rust-lang/rust

JonathanBrouwer · 2026-10-26T01:44:43Z

Successful merges:

tools: remote-test-server: Fix UEFI crash return code #164617 (tools: remote-test-server: Fix UEFI crash return code)
feat!: change return type of TryFromIntError::kind #164549 (feat!: change return type of TryFromIntError::kind)
Add diagnostic items for env::vars / env::vars_os #164893 (Add diagnostic items for env::vars / env::vars_os)
Add regression test for CoerceShared impl with unnormalizable target #164897 (Add regression test for CoerceShared impl with unnormalizable target)
Add regression test for self referential inherent associated type ICE #164908 (Add regression test for self referential inherent associated type ICE)
Cleanup rustdoc-html tests #164925 (Cleanup rustdoc-html tests)

- compiletest detects crash as an error code > 127. - This does not work for UEFI, since UEFI errors are usize by default, and when converting to i32, we just remove the bits in middle. Eg: 0x8000000000000007 becomes 0x80000007 - So in case of crash, we get a negetive value as error instead of the expected signal when the host is linux. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

…acrum tools: remote-test-server: Fix UEFI crash return code - compiletest detects crash as an error code > 127. - This does not work for UEFI, since UEFI errors are usize by default, and when converting to i32, we just remove the bits in middle. Eg: 0x8000000000000007 becomes 0x80000007 - So in case of crash, we get a negetive value as error instead of the expected signal when the host is linux.

…d-return-type, r=ChrisDenton feat!: change return type of `TryFromIntError::kind` - Tracking issue: rust-lang#153978 Change the return type from `&IntErrorKind` to `IntErrorKind`. Since [`IntErrorKind`](https://doc.rust-lang.org/core/num/enum.IntErrorKind.html) implements the `Copy` trait, I think it should be fine to return an owned type. Returning a reference type is appropriate when we want to ensure the return type matches [`ParseIntError::kind`](https://doc.rust-lang.org/core/num/struct.ParseIntError.html#method.kind).

…Denton Add diagnostic items for env::vars / env::vars_os A WIP Clippy lint that uses this can be found at <https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1>

…nilla Add regression test for CoerceShared impl with unnormalizable target Fixes rust-lang#156699 The ICE was fixed by rust-lang#158659

Add regression test for self referential inherent associated type ICE Fixes rust-lang#157774

@Urgau

…l-tests, r=Urgau Cleanup `rustdoc-html` tests r? @Urgau

JonathanBrouwer · 2026-10-26T01:44:56Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

rust-bors · 2026-10-26T01:44:59Z

📌 Commit 89b66c2 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3

…uwer Rollup of 6 pull requests Successful merges: - #164617 (tools: remote-test-server: Fix UEFI crash return code) - #164549 (feat!: change return type of `TryFromIntError::kind`) - #164893 (Add diagnostic items for env::vars / env::vars_os) - #164897 (Add regression test for CoerceShared impl with unnormalizable target) - #164908 (Add regression test for self referential inherent associated type ICE) - #164925 (Cleanup `rustdoc-html` tests)

rust-log-analyzer · 2026-10-26T02:30:03Z

The job test-armhf-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] tests/ui/precondition-checks/cfg-ub-checks-no.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precondition-checks/cfg-ub-checks-no/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/precondition-checks/cfg-ub-checks-no/a", waiting for result
------------------------------------------
--- stderr -------------------------------

thread 'main' (120372) panicked at src/tools/remote-test-client/src/main.rs:332:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)

rust-log-analyzer · 2026-10-26T03:25:37Z

The job test-x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

..                                                 (152/152)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 182: ProtocolError: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.: for command `click: "//*[@id='method.create_an_iterator_from_read']//*[@class='tooltip']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 38: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

rust-bors · 2026-10-26T03:26:00Z

💔 Test for 9cd92f4 failed: CI. Failed job:

auto - test-x86_64-gnu-tools (web logs, enhanced plaintext logs)

rust-bors · 2026-10-26T04:37:40Z

PR #164925, which is a member of this rollup, was unapproved.

rust-bors · 2026-10-26T04:38:08Z

💔 Test for c371776 failed: CI. Failed job:

try - test-armhf-gnu (web logs, enhanced plaintext logs)

sorairolake and others added 14 commits October 19, 2026 08:38

feat!: change return type of TryFromIntError::kind

19577f5

style: apply rustfmt

104e47a

Add regression test for CoerceShared impl with unnormalizable target

a0a67f8

Add regression test for self-referential inherent associated type ICE

7d79665

Add diagnostic items for env::vars / env::vars_os

c19a268

Move rustdoc-html tests in the right folder

7b173db

Improve tests/rustdoc-html/trait/impossible-default.rs

f0fa4d1

Rollup merge of rust-lang#164897 - zakrad:regr-test-156699, r=ShoyuVa…

d9f17dc

…nilla Add regression test for CoerceShared impl with unnormalizable target Fixes rust-lang#156699 The ICE was fixed by rust-lang#158659

Rollup merge of rust-lang#164908 - zakrad:regr-test-157774, r=chenyukang

680fb37

Add regression test for self referential inherent associated type ICE Fixes rust-lang#157774

Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…

89b66c2

…l-tests, r=Urgau Cleanup `rustdoc-html` tests r? @Urgau

rust-bors Bot added the rollup A PR which is a rollup label Oct 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2026

jhpratt mentioned this pull request Oct 26, 2026

Cleanup rustdoc-html tests #164925

Merged

jhpratt closed this Oct 26, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 26, 2026

Navigation Menu

Repository navigation

Rollup of 6 pull requests - #164940

Rollup of 6 pull requests#164940
JonathanBrouwer wants to merge 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-rCORLRu

JonathanBrouwer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Oct 26, 2026

Uh oh!

rust-log-analyzer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

JonathanBrouwer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Oct 26, 2026

Uh oh!

rust-log-analyzer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants