[amirHdev]

View all comments

reduces redundant type-outlives constraints in large canonical responses by comparing region requirements for fully resolved types with region-only components

related to rust-lang/trait-system-refactor-initiative#308

[maxdexh]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 05e774a (05e774a585901d6deaa140d4bc4f4ed6f0768ca5)
Base parent: 41089d0 (41089d07a0a2afc16adfe28a760d94d73d7298a4)

[rust-timer]

Finished benchmarking commit (05e774a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.2%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 1.1%]	11
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-1.2%, 1.1%]	15

Cycles

Results (primary 0.2%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.6%, 2.3%]	7
Regressions ❌ (secondary)	1.6%	[0.7%, 2.5%]	2
Improvements ✅ (primary)	-0.9%	[-1.7%, -0.4%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-1.7%, 2.3%]	14

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	3
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	3

Bootstrap: 490.666s -> 490.065s (-0.12%)
Artifact size: 405.86 MiB -> 406.15 MiB (0.07%)

[maxdexh]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 55ebfab (55ebfabaf7de3092ef106a651b10f11cba33066d)
Base parent: 92b5b8c (92b5b8c87c61b20adc9001b41baf587634a74734)

[rust-timer]

Finished benchmarking commit (55ebfab): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=iffy rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	4
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.1%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.2%, -0.1%]	4

Max RSS (memory usage)

Results (primary 1.3%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.8%, 2.0%]	4
Regressions ❌ (secondary)	2.5%	[1.6%, 4.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	1.3%	[0.8%, 2.0%]	4

Cycles

Results (primary 1.8%, secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 484.843s -> 487.902s (0.63%)
Artifact size: 406.61 MiB -> 406.82 MiB (0.05%)

[rustbot]

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 79 candidates
• Random selection from 20 candidates

[folkertdev]

r? types

[panstromek]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: c228fb2 (c228fb2518373819626e23d221afe91f766af0e6)
Base parent: 29a5d06 (29a5d066d98b58d948d285ba22390a5f849f5938)

[rust-timer]

Finished benchmarking commit (c228fb2): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-5.5%, -2.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.9%	[-5.5%, -2.5%]	3

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 484.783s -> 484.819s (0.01%)
Artifact size: 406.09 MiB -> 406.10 MiB (0.00%)