Repository navigation
Conversation
|
Some changes occurred to the CTFE machinery The reflection data structures are tied exactly to the implementation cc @oli-obk Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
a59d1d8 to
c33e84e
Compare
| )?; | ||
| } | ||
|
|
||
| sym::type_id_docs => { |
There was a problem hiding this comment.
The list of intrinsics here is growing so much that I think it'd make sense to move it to a separate file. (In a separate PR.)
This comment has been minimized.
This comment has been minimized.
c33e84e to
d834d5c
Compare
| } | ||
| } | ||
|
|
||
| sym::type_id_variant_docs => { |
There was a problem hiding this comment.
Maybe we should add a variant-pattern type (similar to what we do with FRTs instead of also having a field variant of many intrinsics) sooner rather than later instead of having to have all these intrinsics duplicated for variants and for normal types. Not for this PR, but just adding them to the type system without exposing them at the AST level shouldn't be too hard (famous last words)
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
d834d5c to
b6997cd
Compare
rust-bors
Bot
added
S-waiting-on-bors
…r=oli-obk reflection: doc attributes from adts, fields, and variants Adds intrinsics and methods to get the raw doc comment strings from adts, fields, and variants. As noted in the tracking issue rust-lang#146922, before stabilizing the interface we should consider whether these methods get the raw strings. r? @oli-obk
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #165134 (comment) Soft conflict with #165079, please wait for that to merge then rebase |
rust-bors
Bot
added
S-waiting-on-author
|
This pull request was unapproved. This PR was contained in a rollup (#165134), which was unapproved. |
Adds intrinsics and methods to get the raw doc comment strings from adts, fields, and variants. As noted in the tracking issue #146922, before stabilizing the interface we should consider whether these methods get the raw strings.
r? @oli-obk