Repository navigation
Conversation
Collaborator
|
Any special-casing of Miri in the standard library requires review. cc @rust-lang/miri |
rustbot
added
O-apple
Collaborator
|
|
Member
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 29, 2026
std: use skip_missing_miri_shims to control when tests should be skipped in Miri due to missing shims try-job: test-x86_64-gnu-aux
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
October 29, 2026 10:07
43cd0c6 to
ce7f68a
Compare
Member
|
I'm pretty okay with this, @rust-lang/libs-ping any thoughts? See the Zulip discussion linked in the top post for context |
Contributor
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
October 31, 2026 10:22
ce7f68a to
4d659d1
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
October 31, 2026 10:27
4d659d1 to
f08ee20
Compare
RalfJung
commented
Oct 31, 2026
| /// Converts a `BorrowedFd` into a reference to a file-like type. | ||
| /// | ||
| #[cfg_attr(all(unix, not(miri)), doc = "```")] | ||
| #[cfg_attr(unix, doc = "```")] |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
October 31, 2026 12:14
f08ee20 to
5439f19
Compare
rustbot
added
A-CI
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
October 31, 2026 12:14
5439f19 to
3aee2ea
Compare
This comment has been minimized.
This comment has been minimized.
…ped in Miri due to missing shims
RalfJung
force-pushed
the
skip_missing_miri_shims
branch
from
November 2, 2026 21:41
3aee2ea to
573f710
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See prior discussion on Zulip.
Docs PR: rust-lang/std-dev-guide#86
Entirely remove testing on Windows, there is just too much we don't support there.
Also don't run std doc tests any more as there is no way to disable all doctests in a module, and marking every single test is too tedious IMO.
r? @tgross35
try-job: test-x86_64-gnu-aux