Repository navigation
Rollup of 21 pull requests - #165178
Closed
JonathanBrouwer wants to merge 48 commits into
Closed
Rollup of 21 pull requests#165178JonathanBrouwer wants to merge 48 commits into
JonathanBrouwer wants to merge 48 commits into
Conversation
When a format string is not a literal in the source, e.g. when it is
produced by `concat!`, the offsets of printf- and shell-style
specifiers are relative to the expanded string rather than to the
source. `check_foreign!` still used them to place a machine-applicable
suggestion, which could rewrite unrelated source text such as turning
`concat!` into `c{}cat!`, or ICE when the span landed inside a
multibyte character.
When the format string is not a source literal, explain the
translation in a note instead, e.g. "`%d` should be written as `{}`",
and don't emit the suggestion. For specifiers that cannot be
translated, point the note at the whole format string argument
instead of a span computed from those offsets; the output is the same
as before. The output for format strings written as literals is
unchanged.
These are always checked in attribute parsing
```
error: expected expression, found `let` statement
--> issue-87291.rs:2:5
|
2 | - let a = opt1.map(|_| {
| - ^^^
| |
| expected an expression after this
|
= note: only supported directly in conditions of `if` and `while` expressions
```
By updating backtrace, curl, stacker. Also update flate2 and miniz_oxide to avoid introducing a duplicate dependency.
fixup cranelift
This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
…c_passes` to `rustc_attr_parsing`
…ross35 Add behavior tests for `Arc` and `Rc` See <rust-lang#141348 (comment)>. r? @tgross35
…-perf, r=notriddle rustdoc: Fix performance regression for private documented items Should help with rust-lang#161362. The idea is to not (doc) inline private reexports by default. That will save us a lot of `clean`ing for external items and for html pages generation. r? ghost
…f, r=khyperia Remove GenericArgRef This removes `GenericArgsRef`, renaming it to `GenericArgs`. `GenericArgs` used to be an unsized version of `GenericArgsRef`, the reference being just a type alias, but really having access to this unsized type available was not necessary. This also makes `GenericArgs` a tuple struct, giving us the possibility to change its representation in the future. r? @khyperia > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.
Member
Author
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 30, 2026
Rollup of 21 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for c02e8f7 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 30, 2026
…uwer Rollup of 21 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for 44b4d86 failed: CI. Failed job:
|
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 30, 2026
…uwer Rollup of 7 perf-sensitive pull requests Successful merges: - #163339 (MIR move elimination [5/6]: Storage reconstruction) - #163525 (Move lang item collection to the resolver) - #163928 (do not prefer trivially true candidates with `-Znext-solver` ) - #164341 (Expand an early return case in `coerce_unsized`) - #164484 (Use adaptive sparse encoding for metadata tables) - #164607 (destringlyfy lint infrastructure) - #165160 (New solver opts for diesel (part 3)) > [!WARNING] > This rollup conflicts with pending auto build #165178 and may need to be recreated if the pending build succeeds.
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 31, 2026
…uwer Rollup of 7 perf-sensitive pull requests Successful merges: - #163339 (MIR move elimination [5/6]: Storage reconstruction) - #163525 (Move lang item collection to the resolver) - #163928 (do not prefer trivially true candidates with `-Znext-solver` ) - #164341 (Expand an early return case in `coerce_unsized`) - #164484 (Use adaptive sparse encoding for metadata tables) - #164607 (destringlyfy lint infrastructure) - #165160 (New solver opts for diesel (part 3)) > [!WARNING] > This rollup conflicts with pending auto build #165178 and may need to be recreated if the pending build succeeds.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 31, 2026
…uwer Rollup of 7 perf-sensitive pull requests Successful merges: - #163339 (MIR move elimination [5/6]: Storage reconstruction) - #163525 (Move lang item collection to the resolver) - #163928 (do not prefer trivially true candidates with `-Znext-solver` ) - #164341 (Expand an early return case in `coerce_unsized`) - #164484 (Use adaptive sparse encoding for metadata tables) - #164607 (destringlyfy lint infrastructure) - #165160 (New solver opts for diesel (part 3)) > [!WARNING] > This rollup conflicts with pending auto build #165178 and may need to be recreated if the pending build succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ArcandRc#164851 (Add behavior tests forArcandRc)!. #161781 (Don't emit InlineAsm terminator if input operand is!.)clobber_abi#163839 (Fix the floating point clobbers of RISC-Vclobber_abi)advance_back_byonFuse#165132 (Implementadvance_back_byonFuse)concat!output #163371 (Don't suggest replacing foreign format specifiers inconcat!output)letwhen expression is expected #164920 (Point at prior token onletwhen expression is expected)doc(keyword)anddoc(attribute)attributes checks fromrustc_passestorustc_attr_parsing#165128 (Movedoc(keyword)anddoc(attribute)attributes checks fromrustc_passestorustc_attr_parsing)Failed merges:
r? @ghost
Create a similar rollup