Skip to content

Remove expected_name_value function and use the one from AcceptContext instead - #165187

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:cleanup-invalid-doc-attribute-err
Open

Remove expected_name_value function and use the one from AcceptContext instead#165187
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:cleanup-invalid-doc-attribute-err

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Oct 30, 2026

Copy link
Copy Markdown
Member

I think it's been enough time for this "it will become a hard error in the future" warning, so time to make it an error. :)

Part of #149865.

r? @JonathanBrouwer

@rustbot

rustbot commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2026
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 30, 2026
@JonathanBrouwer

JonathanBrouwer commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I think this needs an FCP, probably from T-rustdoc?
If we're doing this anyways, does it make sense to "go big or go home" and remove more or even all uses of the INVALID_DOC_ATTRIBUTES lint, and replace them with errors?

@GuillaumeGomez

GuillaumeGomez commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

Hum... Fair enough. Gonna update and start the FCP.

@GuillaumeGomez

GuillaumeGomez commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

On second thought, maybe not the best idea right away considering how many INVALID_DOC_ATTRIBUTES instances there are. I'll tweak the API to add a future_error: bool instead.

@GuillaumeGomez

GuillaumeGomez commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

On second second thought, yeah let's remove all uses of this lint.

@JonathanBrouwer

JonathanBrouwer commented Oct 30, 2026

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2026
@rust-bors

rust-bors Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #165234) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @rustbot @JonathanBrouwer