Repository navigation
Do attribute target checking on parameters with the new system - #165193
Open
JonathanBrouwer wants to merge 4 commits into
Open
JonathanBrouwer wants to merge 4 commits into
JonathanBrouwer wants to merge 4 commits into
Conversation
This is necessary so the change in the next commit still goes into this path.
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
param-targets
branch
from
October 30, 2026 15:22
0be1553 to
90cb822
Compare
Member
Author
|
Maybe |
This comment has been minimized.
This comment has been minimized.
mejrs
reviewed
Oct 30, 2026
| | | ||
| LL | fn foo(#[doc(alias = "qux")] _x: u32) -> Self::X { | ||
| | ^^^^^^^^^^^^^^^^^^^^^ | ||
| | ^^^^^ |
JonathanBrouwer
force-pushed
the
param-targets
branch
from
October 31, 2026 10:51
90cb822 to
7b437e9
Compare
Member
Author
Yep, I've also been thinking that... Maybe we should get rid of it (not this PR tho) |
Contributor
|
☔ The latest upstream changes (presumably #165234) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a bunch of duplicate diagnostics :)
Behavior should be preserved, in the sense that any code error after this change if and only if it did before this change.