lint: Make `unsafe_op_in_unsafe_fn` trigger in external macros by Enselic · Pull Request #165210 · rust-lang/rust

Enselic · 2026-10-30T21:30:04Z

The unsafety does not go away just because the unsafe operations are in an external macro, so make the lint report in external macros.

This PR will eventually close #112504, but a bunch of preparatory commits are required first, that I will prepare separately.

Draft PR Notes

The purpose of the #[allow(unsafe_op_in_unsafe_fn)] hacks in the #[alloc_error_handler] and #[global_allocator] macros are to produce a usable toolchain with minimal changes. They are not meant as long-term fixes.

Blockers

We are waiting for select_macro: Stop erasing Sender/Receiver lifetime to please non-NLL borrowck crossbeam-rs/crossbeam#1353 to be included in an official release.
tests: Remove issue-106126-good-path-bug.rs (it does not work) #165583
bytecheck_derive: Add unsafe { ... } and // SAFETY: ... for field accesses rkyv/bytecheck#43
TODO: Add rest

LLM disclosure

I used an LLM to to help me find the right location for a fix. I wrote the fix (which happens to be trivial) and test code myself. The only LLM-written code is the temporary #[allow(unsafe_op_in_unsafe_fn)] hacks.

The unsafety does not go away just because the unsafe operations are in an external macro, so make the lint report in external macros. NOTE: The purpose of the `#[allow(unsafe_op_in_unsafe_fn)]` hacks in the `#[alloc_error_handler]` and `#[global_allocator]` macros are to produce a usable toolchain with minimal changes. They are not meant as long-term fixes.

rust-log-analyzer · 2026-10-30T22:10:34Z

The job test-aarch64-gnu-llvm-22-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rkyv v0.8.18
[RUSTC-TIMING] rend test:false 10.021
   Compiling rustdoc-json-types v0.1.0 (/checkout/src/rustdoc-json-types)
[RUSTC-TIMING] rkyv test:false 7.082
warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:126:41
    |
126 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:126:41
    |
126 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
    = note: `#[warn(unsafe_op_in_unsafe_fn)]` (part of `#[warn(rust_2024_compatibility)]`) on by default

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:126:41
    |
126 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:126:41
    |
126 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:151:41
    |
151 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:151:41
    |
151 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:151:41
    |
151 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:151:41
    |
151 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:183:41
    |
183 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:183:41
    |
183 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:183:41
    |
183 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:183:41
    |
183 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:209:41
    |
209 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:209:41
    |
209 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:209:41
    |
209 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:209:41
    |
209 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:239:41
    |
239 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:239:41
    |
239 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:239:41
    |
239 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:239:41
    |
239 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:262:41
    |
262 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:262:41
    |
262 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:262:41
    |
262 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:262:41
    |
262 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:348:41
    |
348 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
   --> src/rustdoc-json-types/lib.rs:348:41
    |
348 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^ in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:348:41
    |
348 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: call to unsafe function `rkyv::bytecheck::CheckBytes::check_bytes` is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:348:41
    |
348 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           call to unsafe function
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(
 63 | |     input: proc_macro::TokenStream,
 64 | | ) -> proc_macro::TokenStream {
    | |____________________________- in this expansion of `#[derive(::rkyv::bytecheck::CheckBytes)]`
    |
    = note: consult the function's documentation for information on how to avoid undefined behavior
    = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block
   --> src/rustdoc-json-types/lib.rs:361:41
    |
361 |   #[cfg_attr(feature = "rkyv_0_8", derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize))]
    |                                           ^^^^^^^^^^^^^
    |                                           |
    |                                           dereference of raw pointer
    |                                           in this derive macro expansion
    |
   ::: /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bytecheck_derive-0.8.2/src/lib.rs:62:1
    |
 62 | / pub fn check_bytes_derive(

rust-log-analyzer · 2026-10-30T23:46:54Z

The job test-pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#15 2.119 Building wheels for collected packages: reuse
#15 2.120   Building wheel for reuse (pyproject.toml): started
#15 2.254   Building wheel for reuse (pyproject.toml): finished with status 'done'
#15 2.255   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-linux_x86_64.whl size=132855 sha256=78b18759d7868af836e6c653035275b9564ead1e102ae69b3b788a82f243d193
#15 2.255   Stored in directory: /tmp/pip-ephem-wheel-cache-ogzrdx8e/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#15 2.257 Successfully built reuse
#15 2.257 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, Jinja2, chardet, attrs
#15 2.494 Successfully installed Jinja2-3.1.6 attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#15 2.494 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#15 DONE 2.6s
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#8)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
---
     |
    ::: src/tools/rust-analyzer/crates/vfs-notify/src/lib.rs:93:9
     |
  93 | /         select! {
  94 | |             recv(receiver) -> it => it.ok().map(Event::Message),
  95 | |             recv(watcher_receiver) -> it => Some(Event::NotifyEvent(it.unwrap())),
  96 | |         }
     | |_________- in this macro invocation (#1)
     |
     = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#8)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
---
     |
    ::: src/tools/rust-analyzer/crates/vfs-notify/src/lib.rs:93:9
     |
  93 | /         select! {
  94 | |             recv(receiver) -> it => it.ok().map(Event::Message),
  95 | |             recv(watcher_receiver) -> it => Some(Event::NotifyEvent(it.unwrap())),
  96 | |         }
     | |_________- in this macro invocation (#1)
     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
     = note: requested on the command line with `-W unsafe-op-in-unsafe-fn`

---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#11)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
 851 | |                         ::std::mem::transmute(x)
     | |                         ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
...    |
 857 | /                 $crate::crossbeam_channel_internal!(
 858 |                       @add
 859 |                       $sel
 860 |                       ($($tail)*)
...
 863 |                       ($($cases)* [$i] recv($var) -> $res => $body,)
 864 | |                 )
     | |_________________- in this macro invocation (#11)
...
 976 | /         $crate::crossbeam_channel_internal!(
 977 |               @list
---
     |
    ::: src/tools/rust-analyzer/crates/vfs-notify/src/lib.rs:93:9
     |
  93 | /         select! {
  94 | |             recv(receiver) -> it => it.ok().map(Event::Message),
  95 | |             recv(watcher_receiver) -> it => Some(Event::NotifyEvent(it.unwrap())),
  96 | |         }
     | |_________- in this macro invocation (#1)
     |
     = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#11)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
 850 | |                     unsafe fn unbind<'a, T>(x: &T) -> &'a T {
     | |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...    |
 857 | /                 $crate::crossbeam_channel_internal!(
 858 |                       @add
 859 |                       $sel
 860 |                       ($($tail)*)
...
 863 |                       ($($cases)* [$i] recv($var) -> $res => $body,)
 864 | |                 )
     | |_________________- in this macro invocation (#11)
...
 976 | /         $crate::crossbeam_channel_internal!(
 977 |               @list
---
     |
    ::: src/tools/rust-analyzer/crates/vfs-notify/src/lib.rs:93:9
     |
  93 | /         select! {
  94 | |             recv(receiver) -> it => it.ok().map(Event::Message),
  95 | |             recv(watcher_receiver) -> it => Some(Event::NotifyEvent(it.unwrap())),
  96 | |         }
     | |_________- in this macro invocation (#1)
     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

For more information about this error, try `rustc --explain E0133`.

rust-log-analyzer · 2026-10-31T11:59:00Z

The job test-aarch64-gnu-llvm-22-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/unsafe/issue-106126-good-path-bug.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/unsafe/issue-106126-good-path-bug.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/unsafe/issue-106126-good-path-bug" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/unsafe/issue-106126-good-path-bug/auxiliary" "--edition=2015"
stdout: none
--- stderr -------------------------------
error[E0133]: call to unsafe function `__unsf` is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/issue-106126-good-path-bug.rs:10:1
   |
LL | foo!();
   | ^^^^^^ call to unsafe function
   |
---
To only update this specific test, also pass `--test-args unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg/auxiliary" "--edition=2015"
stdout: none
--- stderr -------------------------------
error[E0133]: call to unsafe function `unsf` is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:13:5
   |
LL |     unsf(); //~ ERROR call to unsafe function `unsf` is unsafe
   |     ^^^^^^ call to unsafe function
   |
   = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:11:1
   |
LL | pub unsafe fn foo() {
   | ^^^^^^^^^^^^^^^^^^^
   = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
note: the lint level is defined here
  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:4:9
   |
LL | #![deny(unsafe_op_in_unsafe_fn)] //~ NOTE
   |         ^^^^^^^^^^^^^^^^^^^^^^

error[E0133]: call to unsafe function `unsf` is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:17:5
   |
LL |     unsf(); //~ ERROR call to unsafe function `unsf` is unsafe
   |     ^^^^^^ call to unsafe function
   |
   = note: consult the function's documentation for information on how to avoid undefined behavior
   = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

error[E0133]: dereference of raw pointer is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:25:13
   |
LL |     let y = *x; //~ ERROR dereference of raw pointer is unsafe and requires unsafe block
   |             ^^ dereference of raw pointer
   |
   = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:23:1
   |
LL | pub unsafe fn bar(x: *const i32) -> i32 {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

error[E0133]: dereference of raw pointer is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:29:9
   |
LL |     y + *x //~ ERROR dereference of raw pointer is unsafe and requires unsafe block
   |         ^^ dereference of raw pointer
   |
   = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
   = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

error[E0133]: use of mutable static is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:38:13
   |
LL |     let y = BAZ; //~ ERROR use of mutable static is unsafe and requires unsafe block
   |             ^^^ use of mutable static
   |
   = note: mutable statics can be mutated by multiple threads: aliasing violations or data races will cause undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:36:1
---

error[E0133]: use of mutable static is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:42:9
   |
LL |     y + BAZ //~ ERROR use of mutable static is unsafe and requires unsafe block
   |         ^^^ use of mutable static
   |
   = note: mutable statics can be mutated by multiple threads: aliasing violations or data races will cause undefined behavior
   = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

error[E0133]: call to unsafe function `unsf` is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:48:36
   |
LL | macro_rules! unsafe_macro { () => (unsf()) }
   |                                    ^^^^^^ call to unsafe function
...
LL |     unsafe_macro!();
   |     --------------- in this macro invocation
   |
---

error[E0133]: call to unsafe function `unsf` is unsafe and requires unsafe block
##[error]  --> /checkout/tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-block-sugg.rs:48:36
   |
LL | macro_rules! unsafe_macro { () => (unsf()) }
   |                                    ^^^^^^ call to unsafe function
...
LL |     unsafe_macro!();
   |     --------------- in this macro invocation
   |

…block-sugg.*

To not fail the test when issue 112504 is fixed. Alternatively, we could simply enclose in an unsafe block, like this: unsafe { __unsf(); } but instead allowing `unsafe_op_in_unsafe_fn` keeps the reproducer as similar as possible to the original reproducer.

rust-log-analyzer · 2026-10-31T16:35:41Z

The job test-pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#15 2.701 Building wheels for collected packages: reuse
#15 2.702   Building wheel for reuse (pyproject.toml): started
#15 2.875   Building wheel for reuse (pyproject.toml): finished with status 'done'
#15 2.876   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-linux_x86_64.whl size=132855 sha256=78b18759d7868af836e6c653035275b9564ead1e102ae69b3b788a82f243d193
#15 2.876   Stored in directory: /tmp/pip-ephem-wheel-cache-8djwsuzu/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#15 2.878 Successfully built reuse
#15 2.879 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, Jinja2, chardet, attrs
#15 3.194 Successfully installed Jinja2-3.1.6 attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#15 3.195 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#15 DONE 3.3s
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#8)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
---
     |
    ::: src/tools/rust-analyzer/crates/rust-analyzer/tests/slow-tests/support.rs:540:5
     |
 540 | /     select! {
 541 | |         recv(receiver) -> msg => Ok(msg.ok()),
 542 | |         recv(after(timeout)) -> _ => Err(Timeout),
 543 | |     }
     | |_____- in this macro invocation (#1)
     |
     = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#8)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
---
     |
    ::: src/tools/rust-analyzer/crates/rust-analyzer/tests/slow-tests/support.rs:540:5
     |
 540 | /     select! {
 541 | |         recv(receiver) -> msg => Ok(msg.ok()),
 542 | |         recv(after(timeout)) -> _ => Err(Timeout),
 543 | |     }
     | |_____- in this macro invocation (#1)
     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>
     = note: requested on the command line with `-W unsafe-op-in-unsafe-fn`

---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#11)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
 851 | |                         ::std::mem::transmute(x)
     | |                         ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
...    |
 857 | /                 $crate::crossbeam_channel_internal!(
 858 |                       @add
 859 |                       $sel
 860 |                       ($($tail)*)
...
 863 |                       ($($cases)* [$i] recv($var) -> $res => $body,)
 864 | |                 )
     | |_________________- in this macro invocation (#11)
...
 976 | /         $crate::crossbeam_channel_internal!(
 977 |               @list
---
     |
    ::: src/tools/rust-analyzer/crates/rust-analyzer/tests/slow-tests/support.rs:540:5
     |
 540 | /     select! {
 541 | |         recv(receiver) -> msg => Ok(msg.ok()),
 542 | |         recv(after(timeout)) -> _ => Err(Timeout),
 543 | |     }
     | |_____- in this macro invocation (#1)
     |
     = note: consult the function's documentation for information on how to avoid undefined behavior
note: an unsafe function restricts its caller, but its body is safe by default
---
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#9)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#10)
     |   in this expansion of `$crate::crossbeam_channel_internal!` (#11)
...
  30 | /         $crate::crossbeam_channel_internal!(
  31 | |             @case
  32 | |             ($($head)*)
  33 | |             ()
  34 | |             ()
  35 | |         )
     | |_________- in this macro invocation (#6)
...
 105 | /         $crate::crossbeam_channel_internal!(
 106 | |             @list
 107 | |             ($($tail)*)
 108 | |             ($($head)* $case ($($args)*) $(-> $res)* => { $body },)
 109 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#4)
     |           in this macro invocation (#5)
---
 359 |               $default
 360 | |         )
     | |_________- in this macro invocation (#9)
...
 369 | /         $crate::crossbeam_channel_internal!(
 370 | |             @case
 371 | |             ($($tail)*)
 372 | |             ($($cases)* recv($r) -> $res => $body,)
 373 | |             $default
 374 | |         )
     | |         -
     | |_________|
     | |_________in this macro invocation (#7)
     |           in this macro invocation (#8)
...
 693 | /         $crate::crossbeam_channel_internal!(
 694 |               @add
 695 |               _sel
 696 |               ($($cases)*)
...
 732 |               ()
 733 | |         )
     | |_________- in this macro invocation (#10)
...
 850 | |                     unsafe fn unbind<'a, T>(x: &T) -> &'a T {
     | |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...    |
 857 | /                 $crate::crossbeam_channel_internal!(
 858 |                       @add
 859 |                       $sel
 860 |                       ($($tail)*)
...
 863 |                       ($($cases)* [$i] recv($var) -> $res => $body,)
 864 | |                 )
     | |_________________- in this macro invocation (#11)
...
 976 | /         $crate::crossbeam_channel_internal!(
 977 |               @list
---
     |
    ::: src/tools/rust-analyzer/crates/rust-analyzer/tests/slow-tests/support.rs:540:5
     |
 540 | /     select! {
 541 | |         recv(receiver) -> msg => Ok(msg.ok()),
 542 | |         recv(after(timeout)) -> _ => Err(Timeout),
 543 | |     }
     | |_____- in this macro invocation (#1)
     = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html>

[RUSTC-TIMING] project_model test:true 2.722
[RUSTC-TIMING] rust_analyzer test:false 0.347
For more information about this error, try `rustc --explain E0133`.
[RUSTC-TIMING] slow_tests test:true 0.885
error: `rust-analyzer` (test "slow-tests") generated 2 warnings
error: warnings are denied by `build.warnings` configuration
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] proc_macro_api test:true 2.051
[RUSTC-TIMING] hir_def test:true 9.061
[RUSTC-TIMING] hir_ty test:true 14.630

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2026

TEMP: rustdoc-json-types: Disable rkyv_0_8

c703907

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 30, 2026

Enselic mentioned this pull request Oct 31, 2026

select_macro: Stop erasing Sender/Receiver lifetime to please non-NLL borrowck crossbeam-rs/crossbeam#1353

Merged

TEMP HACK: rust-analyzer: allow(unsafe_op_in_unsafe_fn)

e2cfbce

rustbot added the T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. label Oct 31, 2026

Enselic added 2 commits October 31, 2026 16:51

TEMP HACK: rm tests/ui/unsafe/unsafe_op_in_unsafe_fn/wrapping-unsafe-…

50e2d77

…block-sugg.*

TEMP HACK: rust-analyzer: allow(unsafe_op_in_unsafe_fn)

f255a42

This was referenced Nov 2, 2026

Don't trim path for unsafe_op_in_unsafe_fn lints #106157

Merged

bytecheck_derive: Add unsafe { ... } and // SAFETY: ... for field accesses rkyv/bytecheck#43

Open

tests: Remove issue-106126-good-path-bug.rs (it does not work) #165583

Closed

Navigation Menu

Repository navigation

lint: Make `unsafe_op_in_unsafe_fn` trigger in external macros - #165210

lint: Make `unsafe_op_in_unsafe_fn` trigger in external macros#165210
Enselic wants to merge 6 commits into
rust-lang:mainfrom
Enselic:minimal-unsafe_op_in_unsafe_fn-fix

Enselic commented Oct 30, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Oct 30, 2026

Uh oh!

rust-log-analyzer commented Oct 30, 2026

Uh oh!

rust-log-analyzer commented Oct 31, 2026

Uh oh!

rust-log-analyzer commented Oct 31, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Enselic commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR Notes

Blockers

LLM disclosure

Uh oh!

rust-log-analyzer commented Oct 30, 2026

Uh oh!

rust-log-analyzer commented Oct 30, 2026

Uh oh!

rust-log-analyzer commented Oct 31, 2026

Uh oh!

rust-log-analyzer commented Oct 31, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Enselic commented Oct 30, 2026 •

edited

Loading