Repository navigation
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @dingxiangfei2009 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
qouteall
force-pushed
the
doc-fix-coroutinewitness
branch
from
October 31, 2026 05:35
804e0a3 to
f838c3d
Compare
This comment has been minimized.
This comment has been minimized.
qouteall
force-pushed
the
doc-fix-coroutinewitness
branch
from
November 1, 2026 01:40
f838c3d to
e11a546
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed outdated "This should only appear as part of the
CoroutineArgs."The "A type representing the types stored inside a coroutine." is not fully accurate because witness type doesn't include upvars, which are also stored in coroutine, so edited.
Added description that it's not a data type, and is used in trait solving.
About LLM: The PR is written manually. The outdated doc was noticed when manually reading code. LLM was used for help understanding the compiler codebase. Changes checked by LLM.