Repository navigation
error when a command line flag lowers a -F forbid - #165669
Albab-Hasan wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-review
|
Error: Failed to set assignee to
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
r? compiler |
|
cc @folkertdev |
|
yes, this is a breaking change. the motivation here is that we want to desugar |
| | ^ help: if this is intentional, prefix it with an underscore: `_x` | ||
| | | ||
| = note: requested on the command line with `-F unused-variables` | ||
| = note: `forbid` lint level was set on command line (`-F unused_variables`) |
There was a problem hiding this comment.
The diagnostic could also explain where the allow(unused) comes from, could you add a separate note for that?
a later `-A`, `-W` or `--force-warn` for a lint forbidden by an earlier `-F` was silently ignored while the same order as crate attributes is E0453. command line levels now go through `insert_spec` like attributes so `-F dead_code -A dead_code` is E0453 too. lint groups also hard error instead of the `forbidden_lint_groups` future compat warning since the command line never let them lower a forbid.
the E0453 for a command line flag has no span so it only said where the `forbid` came from. it now also names the flag that tried to lower it.
95dff70 to
615f932
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
added the note so it now says |
-F x -A xon the command line silently kept the forbid while the crate attribute form is E0453. now both error. groups hard error too instead of theforbidden_lint_groupsfcw since the cli never let them lower a forbid.the skip started as the #70918 hack for #70819 and #86970 moved it into
add_command_line. related #133346 #81670cc @jyn514