Repository navigation
Rollup of 9 pull requests - #165698
Merged
Merged
Rollup of 9 pull requests#165698
Conversation
…s of `Type::is_doc_subtype_of`
`addr_of` sounds too much like the `addr_of!` macro or any other operation using raw pointers. It's also consistent with `ty_ref` and `expr_array_ref`.
This matches the order in which it is actually written in code.
This allows removing some clones and simplifies the code since it only needs to work with up to two selflike arguments, which is all we need.
This removes several clones and works since each method def only gets expanded once. It also requires inlining `create_derived_impl` to avoid borrow checking errors.
Some platforms like UEFI do not support real sub-processes. Hoever, it is possible to launch a program from another. Thus, while Command::spawn is not possible on UEFI, APIs which wait for the result, (such as Command::output) are fine. Similar to what was done for Command::output in past, make Command::status impl platform specific, i.e. move it into sys/process/mod.rs. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Use a custom implementation for Command::status for UEFI, that does not rely on Command::spawn. While I am only writing one for UEFI, judging by the implementation of output just above this, other platforms might also add their own in the future. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
```
error: the constant `N` is not of type `usize`
--> $DIR/bad-subst-const-kind.rs:8:31
|
LL | impl<const N: u64> Q for [u8; N] {
| ------------ ^ array length expected `usize`, found `u64`
| |
| `N` defined here
|
= note: the length of array `[u8; N]` must be type `usize`
```
When evaluating an array type's length we don't have accurate spans for that hir node, because evaluation happens on types. Keep the Span for the whole array type that we can use later to try and find the hir node and extract the right span to use in the diagnostic.
…ives or `dyn` for example)
…e-in-helper-thread, r=petrochenkov Make `Proxy` weak reference as it seems that it is not dropped at all Split from rust-lang#165506 which makes `Proxy` droppable, which locally fixes the issue: ```rust thread 'jobserver::jobserver_and_j' (126990) panicked at src/tools/cargo/tests/testsuite/jobserver.rs:411:10: ---- expected: tests/testsuite/jobserver.rs:405:27 ++++ actual: stderr 1 1 | [WARNING] a `-j` argument was passed to Cargo but Cargo is also configured with an external jobserver in its environment, ignoring the `-j` parameter 2 2 | [COMPILING] foo v0.0.1 ([ROOT]/foo) 3 3 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s 4 + make[1]: INTERNAL: Exiting with 1 jobserver tokens available; should be 2! ``` (see rust-lang#162848 (comment)). r? @petrochenkov
Add regression test for unsafe diagnostic attributes Adds a regression test for this issue: rust-lang#165692 I'm refactoring some things and would like to make sure I don't accidentally change the behaviour here cc @mejrs
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 9, 2026
Rollup of 9 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fefe61b (parent) -> 7f56606 (this PR) Test differencesShow 195 test diffsStage 1
Stage 2
Additionally, 157 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7f56606f4dd7194a437f3bf2199ab1bd2fd94677 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (7f56606): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -5.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 483.426s -> 483.422s (-0.00%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: fefe61bee0 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
Member
Author
|
@rust-timer triage all |
Collaborator
Running triage with 15 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#165161 f91f1a6
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.3% | [0.2%, 0.3%] | 4 |
| Regressions ❌ (secondary) |
0.0% | [0.0%, 0.0%] | 1 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.2%] | 3 |
| Improvements ✅ (secondary) |
-0.3% | [-0.4%, -0.1%] | 8 |
| All ❌✅ (primary) | 0.1% | [-0.2%, 0.3%] | 7 |
Max RSS (memory usage)
Results (primary -5.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-5.4% | [-5.4%, -5.4%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -5.4% | [-5.4%, -5.4%] | 1 |
Cycles
Results (secondary -2.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-2.4% | [-2.4%, -2.4%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This perf run didn't have relevant results for this metric.
#165663 713ca2a Avoid repeated gated spans snapshots during macro matching
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-1.2% | [-3.1%, -0.2%] | 23 |
| Improvements ✅ (secondary) |
-0.4% | [-1.4%, -0.1%] | 19 |
| All ❌✅ (primary) | -1.2% | [-3.1%, -0.2%] | 23 |
Max RSS (memory usage)
Results (primary -3.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-3.6% | [-3.6%, -3.6%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -3.6% | [-3.6%, -3.6%] | 1 |
Cycles
Results (primary -0.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.2% | [2.3%, 4.0%] | 2 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-1.8% | [-2.0%, -1.5%] | 4 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-2.0%, 4.0%] | 6 |
Binary size
This perf run didn't have relevant results for this metric.
#165637 65d675c library: std: process: Make Command::status platform specific
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -4.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-4.1% | [-4.1%, -4.1%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -4.1% | [-4.1%, -4.1%] | 1 |
Cycles
Results (primary 3.3%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.3% | [3.3%, 3.3%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 3.3% | [3.3%, 3.3%] | 1 |
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.0% | [-0.0%, -0.0%] | 3 |
| All ❌✅ (primary) | - | - | 0 |
#163571 55d4d53 [rustdoc] Render Deref methods on aliased items
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
2.6% | [0.7%, 6.0%] | 5 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.7% | [-1.7%, -1.7%] | 1 |
| All ❌✅ (primary) | 2.6% | [0.7%, 6.0%] | 5 |
Max RSS (memory usage)
Results (primary -3.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-3.9% | [-3.9%, -3.9%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -3.9% | [-3.9%, -3.9%] | 1 |
Cycles
Results (primary 3.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.9% | [3.9%, 3.9%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 3.9% | [3.9%, 3.9%] | 1 |
Binary size
This perf run didn't have relevant results for this metric.
#164712 170ed8a Reject unexpanded attributes in attributes
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -5.5%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-5.5% | [-5.5%, -5.5%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -5.5% | [-5.5%, -5.5%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165516 f9c53bc Point at array length instead of whole array type
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -5.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-5.1% | [-5.1%, -5.1%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -5.1% | [-5.1%, -5.1%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165674 643f183 Add regression test for issue 118449
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -5.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-5.4% | [-5.4%, -5.4%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -5.4% | [-5.4%, -5.4%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165676 6e04bb3 Make Proxy weak reference as it seems that it is not dropped at all
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -5.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-5.7% | [-5.7%, -5.7%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -5.7% | [-5.7%, -5.7%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165695 62fbf0e Add regression test for unsafe diagnostic attributes
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-3.7% | [-3.7%, -3.7%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -3.7% | [-3.7%, -3.7%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_builtin_macroscleanup, part 9 #165161 (rustc_builtin_macroscleanup, part 9)Derefmethods on aliased items #163571 ([rustdoc] RenderDerefmethods on aliased items)Proxyweak reference as it seems that it is not dropped at all #165676 (MakeProxyweak reference as it seems that it is not dropped at all)r? @ghost
Create a similar rollup