Repository navigation
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
For pointer authentication and `init-fini` enabled, the loader authenticates every `.init_array` and `.fini_array` entry with the init/fini signing schema. However, rust only signs function pointers with `extern "C"` and `extern "system"` ABIs, all other ABIs stay unsigned and failed authentication when the loader ran it. Also, report an error for such entries (and suggest supported ABI).
`init-fini-address-discrimination` was mapped the wrong way round: * enabling it selected (incorrect) hardware address discrimination, * disabling it selected the synthetic placeholder `1`. To make the matters even worst there was no way to disable it. This patch cleans it up, so that Rust follows Clang in enabling (the default) placeholder `1`. I've followed Clang and split the flag for enabling init/fini from init/fini's address discriminator when the ABI version is calculated.
jchlanda
force-pushed
the
jakub/init_fini_addr
branch
from
November 12, 2026 14:12
5e457f8 to
6e04572
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings three main groups of fixes:
1(later resolved by the loader).r? @davidtwco