Repository navigation
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 10, 2026 16:00
d7d5222 to
3a6417a
Compare
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 12, 2026 08:56
3a6417a to
b489285
Compare
rustbot
added
A-rustdoc-json
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 12, 2026 09:10
b489285 to
73cdfb4
Compare
/!\ the test suite is has not been updated /!\
/!\ the #legal revision of field-access.rs has not been updated /!\
/!\ the test suite is has not been updated /!\ the ICE we are currently fixing uses the debug print of view types, which was `unimplemented!()`, which triggered another ICE. this commit adds an implementation of `Debug` for `ty::View`, which gives us a much more interesting backtrace (which is fixed by the next commit).
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 12, 2026 15:04
73cdfb4 to
7d7b53b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
over #165694 and #165565.