Skip to content

Move more rustc lint attributes to lint helpers. - #165865

Open
mejrs wants to merge 4 commits into
rust-lang:mainfrom
mejrs:more_lint_attrs
Open

Move more rustc lint attributes to lint helpers.#165865
mejrs wants to merge 4 commits into
rust-lang:mainfrom
mejrs:more_lint_attrs

Conversation

@mejrs

@mejrs mejrs commented Nov 12, 2026

Copy link
Copy Markdown
Member

Part 2 of implementing #160808

(For part 1, see #163625)

@rustbot

rustbot commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @vakaras

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-iterators Area: Iterators A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-slice-vec Area: `[T]` and `Vec<T>` A-str Area: `str` and `String` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 12, 2026
@rustbot

rustbot commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 79 candidates
  • Random selection from 19 candidates

JonathanBrouwer
JonathanBrouwer reviewed Nov 12, 2026
View reviewed changes
Comment thread compiler/rustc_abi/src/layout/ty.rs
#[derive(Copy, Clone, PartialEq, Eq, Hash, StableHash)]
#[rustc_pass_by_value]
#[cfg_attr(bootstrap, rustc_pass_by_value)]
#[cfg_attr(not(bootstrap), lint::pass_by_value)]

@JonathanBrouwer JonathanBrouwer Nov 12, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be gated by feature = "nightly"?

View changes since the review

@mejrs mejrs Nov 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh it might, thanks

@mejrs mejrs Nov 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, there is a #[cfg(feature = "nightly")] mod ty;

@rust-log-analyzer

This comment has been minimized.

Sign in to view
oli-obk
oli-obk approved these changes Nov 12, 2026
View reviewed changes

@oli-obk oli-obk left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e06e6c6 has been tentatively approved by oli-obk

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165865 - mejrs:more_lint_attrs, r=oli-obk
9ab9b80 
Move more rustc lint attributes to lint helpers.

Part 2 of implementing rust-lang#160808

(For part 1, see rust-lang#163625)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 12, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Nov 12, 2026

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #165878 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2026
@rust-bors

rust-bors Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#165878), which was unapproved.

View changes since this unapproval

@mejrs

mejrs commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Soft conflict with #165861

@mejrs mejrs added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 12, 2026
@rustbot

rustbot commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors

rust-bors Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #165918) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments
@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-iterators Area: Iterators A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-slice-vec Area: `[T]` and `Vec<T>` A-str Area: `str` and `String` S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mejrs @rustbot @rust-log-analyzer @JonathanBrouwer @oli-obk