Repository navigation
Rollup of 6 pull requests - #165884
Closed
JonathanBrouwer wants to merge 28 commits into
Closed
Rollup of 6 pull requests#165884JonathanBrouwer wants to merge 28 commits into
JonathanBrouwer wants to merge 28 commits into
Conversation
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
…ark-Simulacrum compiletest: Add testing for lint machinery at runtime While implementing rust-lang#157707, I noticed that we don't have 'runtime' tests for the diagnostic machinery (i.e. we test the derive macros themselves, but not their output when emitted). This introduces a new way to test this machinery. - Add `//@ aux-lint: file.rs`, which builds a lint library in `auxiliary/file.rs` - Lint libraries link with `rustc_private`, and export a `extern "C" fn register_lints(...)` - A new `compiletest-lint-driver` wraps rustc and installs the provided lints when building the test Included is a simple demo lint for example _AI Disclosure: I used an LLM to plan out the broad structure of the machinery and identify issues; all code in this PR is written by hand_
…g, r=oli-obk view-types: lower view types from HIR
…utes, r=oli-obk reflection: reflect attributes from adts, fields, and variants Introduced a new attribute tool `reflection_placeholder` behind the `TypeId` feature gate. Added intrinsics and methods to query there tool attributes from adts, fields, and variants. Uncertain if the stringifying of the attribute objects before returning them is the right approach. Alternatively, a specific tool attribute structure could be introduced and returned instead of strings. The feature gating also, erroneously, triggers when a user registers a tool attribute with the same name using the `register_tool` feature.
…ieyouxu Update `sysinfo` version to `0.40.3`
cg_llvm: Use an invariant lifetime brand for LLVM attributes This PR changes the type of LLVM attribute references from `&'ll Attribute` to `Attribute<'ll>` with an invariant lifetime brand, to help uphold soundness of the FFI bindings. There should be no change to compiler output. --- After the value migration, this step is thankfully much smaller.
…uwer Some attribute related cleanups
rustbot
added
S-waiting-on-review
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
…uwer Rollup of 6 pull requests Successful merges: - #157721 (compiletest: Add testing for lint machinery at runtime) - #165565 (view-types: lower view types from HIR) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165855 (Update `sysinfo` version to `0.40.3`) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165872 (Some attribute related cleanups)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 25e4bd8 failed: CI. Failed job:
|
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #157721, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 5c7a5ee failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sysinfoversion to0.40.3#165855 (Updatesysinfoversion to0.40.3)r? @ghost
Create a similar rollup