Repository navigation
Rollup of 13 pull requests - #165897
Closed
Zalathar wants to merge 52 commits into
Closed
Rollup of 13 pull requests#165897Zalathar wants to merge 52 commits into
Zalathar wants to merge 52 commits into
Conversation
Rebuilding rustc against statically linked LLVM now reaches the code that locates clang’s profiling runtime that was previously skipped. Bootstrap checks during dry-run mode also need to discover clang-cl, so this change means now run_in_dry_run() adds clang-cl during the planning pass and avoids the panic check later.
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
By default, we optimize cargo and thus need to run the stage2 PGO-instrumented cargo binary to get its profiles. When we opt out of that, we don't have a stage2 cargo, and don't need it, so we just use the regular stage0 cargo there.
rustbot
added
PG-exploit-mitigations
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
Rollup of 13 pull requests Successful merges: - #164707 (Re-enable rustc profile generation for static linked llvm on Windows x64 builds ) - #165068 (Change color usage for highlights) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) Failed merges: - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes)
Member
Author
|
The previous rollup failed in If we see the same failure here, we'll need to investigate further. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for a5b72c9 failed: CI. Failed job:
|
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #165823, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
Member
Author
|
The test-various job did indeed fail, but I think it's a different failure this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
BackendRepr::MemorywithPassMode::Direct#165880 (Remove dead code for returningBackendRepr::MemorywithPassMode::Direct)-Zllvm-tpdeflag torustc_codegen_llvm#164108 (Add unstable-Zllvm-tpdeflag torustc_codegen_llvm)sysinfoversion to0.40.3#165855 (Updatesysinfoversion to0.40.3)Failed merges:
r? @ghost
Create a similar rollup