Repository navigation
Rollup of 18 pull requests - #165908
Closed
JonathanBrouwer wants to merge 66 commits into
Closed
Rollup of 18 pull requests#165908JonathanBrouwer wants to merge 66 commits into
JonathanBrouwer wants to merge 66 commits into
Conversation
```
error[E0599]: no associated function or constant named `bar` found for struct `Foo` in the current scope
--> src/main.rs:3:15
|
3 | let a = Foo::bar();
| ^^^ associated function or constant not found in `Foo`
|
= help: items from traits can only be used if the trait is in scope
help: trait `Bar` which provides `bar` is implemented but not in scope; perhaps you want to import it
|
1 + use some_inner_lib_rename::Bar;
|
```
instead of
```
error[E0599]: no associated function or constant named `bar` found for struct `Foo` in the current scope
--> src/main.rs:3:15
|
3 | let a = Foo::bar();
| ^^^ associated function or constant not found in `Foo`
|
= help: items from traits can only be used if the trait is in scope
help: trait `Bar` which provides `bar` is implemented but not in scope; perhaps you want to import it
|
1 + use some_inner_lib::Bar;
|
```
where crate `some_inner_lib` is in `Cargo.toml` as `some-inner-lib-rename = { package = "some-inner-lib" }`, making `some_inner_lib` inaccessible in the local crate.
…canonical" in diagnostics
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
By default, we optimize cargo and thus need to run the stage2 PGO-instrumented cargo binary to get its profiles. When we opt out of that, we don't have a stage2 cargo, and don't need it, so we just use the regular stage0 cargo there.
rustbot
added
A-rustdoc-json
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
Rollup of 18 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
Contributor
|
⌛ Testing commit 4f1b1bb with merge 323bb5f... Workflow: https://github.com/rust-lang/rust/actions/runs/43412766474 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
…uwer Rollup of 18 pull requests Successful merges: - #164828 (When suggesting path of renamed crate, use the renamed name) - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch) - #165068 (Change color usage for highlights) - #165221 (Canonicalize more comparison operators) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165745 (Don't ICE when a guard condition is a place of type `!`) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) - #165905 (CI: Use a consistent locale when sorting docker build inputs)
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #165745, which is a member of this rollup, was unapproved. This rollup was thus unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
path_matchesandvalue_strfromAttributeExt#165869 (Cleanup: Removepath_matchesandvalue_strfromAttributeExt)BackendRepr::MemorywithPassMode::Direct#165880 (Remove dead code for returningBackendRepr::MemorywithPassMode::Direct)-Zllvm-tpdeflag torustc_codegen_llvm#164108 (Add unstable-Zllvm-tpdeflag torustc_codegen_llvm)!#165745 (Don't ICE when a guard condition is a place of type!)sysinfoversion to0.40.3#165855 (Updatesysinfoversion to0.40.3)r? @ghost
Create a similar rollup