Repository navigation
Rollup of 7 pull requests - #165929
Closed
WaffleLapkin wants to merge 20 commits into
Closed
Rollup of 7 pull requests#165929WaffleLapkin wants to merge 20 commits into
WaffleLapkin wants to merge 20 commits into
Conversation
We also forward the existing `std::vec::from_elem_global` and `std::vec::from_elem_in` to these new associated methods on `Vec`. The module-level methods could potentially be removed in a follow-up.
…the method's return type
This will allow marking EIIs without default impls as not-incomplete and possibly even stabilize them before we get EIIs with default impls fully working across all targets. EIIs without default impls can be implemented (and will be in another PR of mine) in a way that is guaranteed to work on all targets that rustc supports at all. EIIs with default impls afaik however depend on either weak symbols (which are broken on several targets), global constructors writing to a static or having rustc drive the linker (which several projects using Rust don't do).
alloc: Unstably add `Vec::repeat` and `Vec::repeat_in` Tracking issue: rust-lang#164215 We also forward the existing `std::vec::from_elem_global` to `Vec::repeat`. The old module-level method `std::vec::from_elem_in` was unstable and unused, so I've removed it as per reviewer's request. [Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/197181-t-libs.2Fwg-allocators/topic/Custom.20allocators.20with.20vec.21.20and.20fallible.20allocations/with/630260935) r? @clarfonthey
… r=JonathanBrouwer Add a separate feature gate for EIIs with default impls This will allow marking EIIs without default impls as not-incomplete and possibly even stabilize them before we get EIIs with default impls fully working across all targets. EIIs without default impls can be implemented (and will be in another PR of mine) in a way that is guaranteed to work on all targets that rustc supports at all. EIIs with default impls afaik however depend on either weak symbols (which are broken on several targets), global constructors writing to a static or having rustc drive the linker (which several projects using Rust don't do). cc @jdonszelmann
…ustive, r=fmease Emit note for `non_exhaustive` within defining crate for `unreachable_patterns` Original issue: rust-lang#159713 Previous PR: rust-lang#160918 This PR adds a note to the `unreachable_patterns` lint explaining that `#[non_exhaustive]` does not affect exhaustiveness checking within the defining crate when the type is a local enum with the attr `#[non_exhaustive]`.
…r=fmease Small changes to dyn compatibility - Remove unused field - Short-circuit RPITIT check if there aren't any aliases in the return type, to maybe save a little perf.
…=JonathanBrouwer Add `#[rustc_test_entrypoint_marker]` back ! Re-add the unstable and internal `#[rustc_test_entrypoint_marker]` (first sighted in rust-lang#158854)! This is helpful for tools like [Charon](https://github.com/AeneasVerif/charon) to translate test entry points, since once test generation is done there is no simple way of finding these: otherwise one needs to look for statics with `#[rustc_test_marker]`, visit their body, and look for a path to a function inside that body (ugly!) now that synthetic attributes exist doing this is simple and shouldnt cause any regressions :3 (fingers crossed) r? jdonszelmann
…ce, r=panstromek Fix borrowck ICE when a borrow outlives a local in a const block Fixes rust-lang#165684 When borrowck reports a borrow that outlives a local, it adds a label like "...dropped here, when the enclosing closure returns". The code building that label only knew about closures and coroutines and just hit `bug!` for anything else, so a const block made it ICE. I swapped the match for `TyCtxt::def_descr`, which already knows every kind of body. Const blocks are just `AnonConst` though, so `def_descr` calls them "constant expression", which reads weird. So for const blocks (checked via `hir::Node::ConstBlock`) the label now says "when the enclosing const block ends" instead. Coroutines get a bit more specific too, for example "enclosing async block" or "enclosing async fn" instead of just "enclosing coroutine". Added a UI test for the const block case (it ICEs without the fix), and one for the closure / async fn / async block wording.
Use `trim_prefix` in bootstrap The release notes for 1.100 reminded me that we can replace `a.strip_prefix(p).unwrap_or(a)` with `a.trim_prefix(p)`, for both strings and paths. There should be no change in bootstrap behaviour.
rustbot
added
A-attributes
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
Trying commonly failed jobs |
Contributor
|
⌛ Trying commit 55c2cec with merge 8864b64… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/43469416919 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #165882, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Vec::repeatandVec::repeat_in#164043 (alloc: Unstably addVec::repeatandVec::repeat_in)non_exhaustivewithin defining crate forunreachable_patterns#164362 (Emit note fornon_exhaustivewithin defining crate forunreachable_patterns)#[rustc_test_entrypoint_marker]back ! #165879 (Add#[rustc_test_entrypoint_marker]back !)trim_prefixin bootstrap #165914 (Usetrim_prefixin bootstrap)r? @ghost
Create a similar rollup