Skip to content

THIR date check - #3041

Merged
jyn514 merged 3 commits into
rust-lang:mainfrom
simono:thir-date-check
Oct 2, 2026
Merged

jyn514 merged 3 commits into
rust-lang:mainfrom
simono:thir-date-check

Conversation

@simono

@simono simono commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Checked THIR as announced in #3040.

Updated the example output, added explicit tail call checking as a THIR use, and updated the paragraph on thir_body and memory usage.

Hope this is fine 😄

@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 1, 2026
@simono simono changed the title Thir date check THIR date check Oct 1, 2026
@simono

simono commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

r? rustc-dev-guide

@jyn514

jyn514 commented Oct 1, 2026

Copy link
Copy Markdown
Member

Could you please add provenance for all your changes? Links to documentation, source code, tests, etc? Right now this is very hard for me to review.

@simono

simono commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Hi @jyn514,

thanks so much for taking the time to review. Sorry if this is a bit bumpy, I just started with learning about the compiler internals.

Here's some additional context, hope that makes review easier.

  1. attributes was renamed to loop_hint_attrs in rust-lang/rust@d3d2163 Here's some example output.

  2. Explicit tail call checking reads THIR and I added it as another use. Its usage in MIR building.

  3. thir_body is a query now. This was changed in Make building THIR a stealable query rust#85273 and not updated in this guide.

  4. Unsafety checking steals the THIR and frees it afterwards, see comment and source

  5. The THIR types live in rustc_middle::thir.

@jyn514 jyn514 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i appreciate it :) this looks good.

View changes since this review

@jyn514
jyn514 merged commit accd05a into rust-lang:main Oct 2, 2026
4 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 2, 2026
@simono
simono deleted the thir-date-check branch October 2, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants