Repository navigation
refactor(config): prevent unnecessarily returning of ChannelToolchainName - #5175
Merged
rami3l merged 2 commits intoOct 30, 2026
Merged
Conversation
…st_tracking_channels()`
djc
approved these changes
Oct 29, 2026
rami3l
changed the title
ChannelToolchainNameChannelToolchainName
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #5108.
When reviewing #5139 I realized that:
Cfg::list_channels()is imprecise as it really just returned the tracking channels instead of all channels as the name may suggest.ChannelToolchain<'_>already holdsChannelToolchainName, there should be no point in passing both as return values in a single function.This patch only addresses those immediate concerns, and I'll leave #5139 (comment) for the rest of the cleanup. For example, there may be a need of listing all channels in general (rather than just tracking channels), and thus this logic is subject to further changes.
cc @14elias for review.