Repository navigation
Add safety sections to xsetbv and xgetbv - #2252
Open
kiana1kaslana wants to merge 1 commit into
Open
kiana1kaslana wants to merge 1 commit into
kiana1kaslana wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @Amanieu (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
kiana1kaslana
force-pushed
the
safety-doc-xsetbv-xgetbv
branch
2 times, most recently
from
October 13, 2026 01:54
50413fb to
24065c5
Compare
kiana1kaslana
force-pushed
the
safety-doc-xsetbv-xgetbv
branch
from
October 13, 2026 02:08
24065c5 to
05e3a23
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_xsetbv and _xgetbv are declared unsafe but carry no # Safety section. This adds the missing sections.
Both intrinsics address an extended control register selected by the low 32 bits of their first argument, currently only XCR0. The sections require that register to be supported, and for _xsetbv additionally that the written value be legal for the register.
Doc-only change.