Repository navigation
Rustc pull update - #2264
Rustc pull update#2264
Conversation
|
Thanks for the pull request, and welcome! The Rust Project has assigned @Amanieu (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
556cb29 to
f20f173
Compare
|
@sayantn I'm a bit stumped on this I think the only thing that changed is the LLVM version got bumped for nightly? |
|
I have no clue either. Most probably it's some llvm bug, or it's also possible that we need to do a similar preparation routine (as we do in linux) for windows-gnu. Will take a look. In the meantime can you do a ci run with fail-fast disabled? I want to see if other targets stumble across this too |
|
It's reproducible on linux: https://godbolt.org/z/eGaf7YKGf opt-level 2 & 3 fail, but 1 and 0 pass. Setting |
|
Found a smaller repro, apparently LLVM doesn't like if the tiles are loaded before anything else https://godbolt.org/z/KqeWaeKKE |
|
We changed loads to no longer use the LLVM type, maybe that matters? among others |
This updates the rust-version file to ee8268e23d0e2e308b52e4f63df69afb69bc61a4.
5d242c1 to
a24522b
Compare
|
Actually given those symptoms, maybe it's So it's an error that was always there, but we recently stopped ignoring it? Anyway, given that the IR we generate is wrong in a way that we can't easily change, what do we do here? |
|
A bisect pointed me at that PR, f90a2d27c2a1e18f10f4fd84c0dcd02710c37de8. For this particular intrinsic, 92998d2 avoids the LLVM error but then the assertion test fails, and there's a few other intrinsics with different implementation patterns that also fail anyway. I filed rust-lang/rust#165931, we could maybe work around the malformed IR but it's a compiler issue really. I think we should skip the tests for now to unblock merges. |
92998d2 to
4b829e5
Compare
They have the same signature now, so we can unify them. The implementation for tuple is selected based on whether the concatenated string contains field names.
they run into rust-lang/rust#165931, which we can't fix here.
4b829e5 to
d311846
Compare
|
I've disabled the assembly tests on functions that take |
Latest update from rustc.